Skip to content

Add Datanoise PicoADK v2 (RP2350). #2413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Sep 24, 2024
Merged

Add Datanoise PicoADK v2 (RP2350). #2413

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
8ea8e5f
Add Datanoise PicoADK v2 (RP2350).
DatanoiseTV Sep 4, 2024
57dd632
Add pins for Serial 2 (uses ADC shared pins).
DatanoiseTV Sep 5, 2024
2faff80
Update PicoADK v1 and v2 to 4MB Flash
DatanoiseTV Sep 5, 2024
31c3b2b
Re-run makeboards.
DatanoiseTV Sep 5, 2024
a93d553
Merge branch 'master' into picoadk-v2
earlephilhower Sep 5, 2024
08c119c
Add PSRAM menu for Datanoise PicoADK v2.
DatanoiseTV Sep 6, 2024
e0e856e
Merge branch 'picoadk-v2' of github.com:DatanoiseTV/arduino-pico into…
DatanoiseTV Sep 6, 2024
bf3a598
Merge branch 'master' into picoadk-v2
earlephilhower Sep 7, 2024
0fb2dab
Update makeboards.py for PicoADK v2.
DatanoiseTV Sep 7, 2024
31e0aab
Merge branch 'picoadk-v2' of github.com:DatanoiseTV/arduino-pico into…
DatanoiseTV Sep 7, 2024
6d637ce
Update makeboards.py for PicoADK v2.
DatanoiseTV Sep 7, 2024
5f8dd00
Update Build for PicoADK v2.
DatanoiseTV Sep 16, 2024
d2855a8
Update Build for PicoADK v2.
DatanoiseTV Sep 16, 2024
317d74d
Merge branch 'master' into picoadk-v2
DatanoiseTV Sep 20, 2024
b76b040
Trying againg.
DatanoiseTV Sep 20, 2024
f9af81b
Merge branch 'picoadk-v2' of github.com:DatanoiseTV/arduino-pico into…
DatanoiseTV Sep 20, 2024
bf15caa
Set maximum PSRAM speed in variant, remove custom option menus.
DatanoiseTV Sep 20, 2024
2d0c3e8
Update PicoADK v2 PSRAM CS.
DatanoiseTV Sep 20, 2024
65e6da3
Merge branch 'master' into picoadk-v2
DatanoiseTV Sep 23, 2024
05f9f5d
Change USB PID for Datanoise PicoADK v2 and fix double entries.
DatanoiseTV Sep 23, 2024
8932066
Merge branch 'picoadk-v2' of github.com:DatanoiseTV/arduino-pico into…
DatanoiseTV Sep 23, 2024
e92ffd5
Change USB PID for Datanoise PicoADK v2 and fix double entries.
DatanoiseTV Sep 23, 2024
4bc3684
Revert "Change USB PID for Datanoise PicoADK v2 and fix double entries."
DatanoiseTV Sep 23, 2024
45103bf
Update README.md for Datanoise PicoADK versions.
DatanoiseTV Sep 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
98 changes: 98 additions & 0 deletions boards.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10217,6 +10217,104 @@ datanoisetv_picoadk_v2.menu.psram.4mb=4MByte PSRAM
datanoisetv_picoadk_v2.menu.psram.4mb.build.psram_length=0x400000
datanoisetv_picoadk_v2.menu.psram.8mb=8MByte PSRAM
datanoisetv_picoadk_v2.menu.psram.8mb.build.psram_length=0x800000
datanoisetv_picoadk_v2.menu.psramcs.GPIO0=GPIO 0
datanoisetv_picoadk_v2.menu.psramcs.GPIO0.build.psram_cs=-DRP2350_PSRAM_CS=0
datanoisetv_picoadk_v2.menu.psramcs.GPIO1=GPIO 1
datanoisetv_picoadk_v2.menu.psramcs.GPIO1.build.psram_cs=-DRP2350_PSRAM_CS=1
datanoisetv_picoadk_v2.menu.psramcs.GPIO2=GPIO 2
datanoisetv_picoadk_v2.menu.psramcs.GPIO2.build.psram_cs=-DRP2350_PSRAM_CS=2
datanoisetv_picoadk_v2.menu.psramcs.GPIO3=GPIO 3
datanoisetv_picoadk_v2.menu.psramcs.GPIO3.build.psram_cs=-DRP2350_PSRAM_CS=3
datanoisetv_picoadk_v2.menu.psramcs.GPIO4=GPIO 4
datanoisetv_picoadk_v2.menu.psramcs.GPIO4.build.psram_cs=-DRP2350_PSRAM_CS=4
datanoisetv_picoadk_v2.menu.psramcs.GPIO5=GPIO 5
datanoisetv_picoadk_v2.menu.psramcs.GPIO5.build.psram_cs=-DRP2350_PSRAM_CS=5
datanoisetv_picoadk_v2.menu.psramcs.GPIO6=GPIO 6
datanoisetv_picoadk_v2.menu.psramcs.GPIO6.build.psram_cs=-DRP2350_PSRAM_CS=6
datanoisetv_picoadk_v2.menu.psramcs.GPIO7=GPIO 7
datanoisetv_picoadk_v2.menu.psramcs.GPIO7.build.psram_cs=-DRP2350_PSRAM_CS=7
datanoisetv_picoadk_v2.menu.psramcs.GPIO8=GPIO 8
datanoisetv_picoadk_v2.menu.psramcs.GPIO8.build.psram_cs=-DRP2350_PSRAM_CS=8
datanoisetv_picoadk_v2.menu.psramcs.GPIO9=GPIO 9
datanoisetv_picoadk_v2.menu.psramcs.GPIO9.build.psram_cs=-DRP2350_PSRAM_CS=9
datanoisetv_picoadk_v2.menu.psramcs.GPIO10=GPIO 10
datanoisetv_picoadk_v2.menu.psramcs.GPIO10.build.psram_cs=-DRP2350_PSRAM_CS=10
datanoisetv_picoadk_v2.menu.psramcs.GPIO11=GPIO 11
datanoisetv_picoadk_v2.menu.psramcs.GPIO11.build.psram_cs=-DRP2350_PSRAM_CS=11
datanoisetv_picoadk_v2.menu.psramcs.GPIO12=GPIO 12
datanoisetv_picoadk_v2.menu.psramcs.GPIO12.build.psram_cs=-DRP2350_PSRAM_CS=12
datanoisetv_picoadk_v2.menu.psramcs.GPIO13=GPIO 13
datanoisetv_picoadk_v2.menu.psramcs.GPIO13.build.psram_cs=-DRP2350_PSRAM_CS=13
datanoisetv_picoadk_v2.menu.psramcs.GPIO14=GPIO 14
datanoisetv_picoadk_v2.menu.psramcs.GPIO14.build.psram_cs=-DRP2350_PSRAM_CS=14
datanoisetv_picoadk_v2.menu.psramcs.GPIO15=GPIO 15
datanoisetv_picoadk_v2.menu.psramcs.GPIO15.build.psram_cs=-DRP2350_PSRAM_CS=15
datanoisetv_picoadk_v2.menu.psramcs.GPIO16=GPIO 16
datanoisetv_picoadk_v2.menu.psramcs.GPIO16.build.psram_cs=-DRP2350_PSRAM_CS=16
datanoisetv_picoadk_v2.menu.psramcs.GPIO17=GPIO 17
datanoisetv_picoadk_v2.menu.psramcs.GPIO17.build.psram_cs=-DRP2350_PSRAM_CS=17
datanoisetv_picoadk_v2.menu.psramcs.GPIO18=GPIO 18
datanoisetv_picoadk_v2.menu.psramcs.GPIO18.build.psram_cs=-DRP2350_PSRAM_CS=18
datanoisetv_picoadk_v2.menu.psramcs.GPIO19=GPIO 19
datanoisetv_picoadk_v2.menu.psramcs.GPIO19.build.psram_cs=-DRP2350_PSRAM_CS=19
datanoisetv_picoadk_v2.menu.psramcs.GPIO20=GPIO 20
datanoisetv_picoadk_v2.menu.psramcs.GPIO20.build.psram_cs=-DRP2350_PSRAM_CS=20
datanoisetv_picoadk_v2.menu.psramcs.GPIO21=GPIO 21
datanoisetv_picoadk_v2.menu.psramcs.GPIO21.build.psram_cs=-DRP2350_PSRAM_CS=21
datanoisetv_picoadk_v2.menu.psramcs.GPIO22=GPIO 22
datanoisetv_picoadk_v2.menu.psramcs.GPIO22.build.psram_cs=-DRP2350_PSRAM_CS=22
datanoisetv_picoadk_v2.menu.psramcs.GPIO23=GPIO 23
datanoisetv_picoadk_v2.menu.psramcs.GPIO23.build.psram_cs=-DRP2350_PSRAM_CS=23
datanoisetv_picoadk_v2.menu.psramcs.GPIO24=GPIO 24
datanoisetv_picoadk_v2.menu.psramcs.GPIO24.build.psram_cs=-DRP2350_PSRAM_CS=24
datanoisetv_picoadk_v2.menu.psramcs.GPIO25=GPIO 25
datanoisetv_picoadk_v2.menu.psramcs.GPIO25.build.psram_cs=-DRP2350_PSRAM_CS=25
datanoisetv_picoadk_v2.menu.psramcs.GPIO26=GPIO 26
datanoisetv_picoadk_v2.menu.psramcs.GPIO26.build.psram_cs=-DRP2350_PSRAM_CS=26
datanoisetv_picoadk_v2.menu.psramcs.GPIO27=GPIO 27
datanoisetv_picoadk_v2.menu.psramcs.GPIO27.build.psram_cs=-DRP2350_PSRAM_CS=27
datanoisetv_picoadk_v2.menu.psramcs.GPIO28=GPIO 28
datanoisetv_picoadk_v2.menu.psramcs.GPIO28.build.psram_cs=-DRP2350_PSRAM_CS=28
datanoisetv_picoadk_v2.menu.psramcs.GPIO29=GPIO 29
datanoisetv_picoadk_v2.menu.psramcs.GPIO29.build.psram_cs=-DRP2350_PSRAM_CS=29
datanoisetv_picoadk_v2.menu.psramcs.GPIO30=GPIO 30
datanoisetv_picoadk_v2.menu.psramcs.GPIO30.build.psram_cs=-DRP2350_PSRAM_CS=30
datanoisetv_picoadk_v2.menu.psramcs.GPIO31=GPIO 31
datanoisetv_picoadk_v2.menu.psramcs.GPIO31.build.psram_cs=-DRP2350_PSRAM_CS=31
datanoisetv_picoadk_v2.menu.psramfreq.freq109=109 MHz
datanoisetv_picoadk_v2.menu.psramfreq.freq109.build.psram_freq=-DRP2350_PSRAM_MAX_SCK_HZ=109000000
datanoisetv_picoadk_v2.menu.psramfreq.freq133=133 MHz
datanoisetv_picoadk_v2.menu.psramfreq.freq133.build.psram_freq=-DRP2350_PSRAM_MAX_SCK_HZ=133000000
datanoisetv_picoadk_v2.menu.freq.400=400 MHz
datanoisetv_picoadk_v2.menu.freq.400.build.f_cpu=400000000L
datanoisetv_picoadk_v2.menu.freq.50=50 MHz
datanoisetv_picoadk_v2.menu.freq.50.build.f_cpu=50000000L
datanoisetv_picoadk_v2.menu.freq.100=100 MHz
datanoisetv_picoadk_v2.menu.freq.100.build.f_cpu=100000000L
datanoisetv_picoadk_v2.menu.freq.120=120 MHz
datanoisetv_picoadk_v2.menu.freq.120.build.f_cpu=120000000L
datanoisetv_picoadk_v2.menu.freq.125=125 MHz
datanoisetv_picoadk_v2.menu.freq.125.build.f_cpu=125000000L
datanoisetv_picoadk_v2.menu.freq.128=128 MHz
datanoisetv_picoadk_v2.menu.freq.128.build.f_cpu=128000000L
datanoisetv_picoadk_v2.menu.freq.133=133 MHz
datanoisetv_picoadk_v2.menu.freq.133.build.f_cpu=133000000L
datanoisetv_picoadk_v2.menu.freq.150=150 MHz
datanoisetv_picoadk_v2.menu.freq.150.build.f_cpu=150000000L
datanoisetv_picoadk_v2.menu.freq.175=175 MHz
datanoisetv_picoadk_v2.menu.freq.175.build.f_cpu=175000000L
datanoisetv_picoadk_v2.menu.freq.200=200 MHz
datanoisetv_picoadk_v2.menu.freq.200.build.f_cpu=200000000L
datanoisetv_picoadk_v2.menu.freq.225=225 MHz
datanoisetv_picoadk_v2.menu.freq.225.build.f_cpu=225000000L
datanoisetv_picoadk_v2.menu.freq.240=240 MHz
datanoisetv_picoadk_v2.menu.freq.240.build.f_cpu=240000000L
datanoisetv_picoadk_v2.menu.freq.250=250 MHz
datanoisetv_picoadk_v2.menu.freq.250.build.f_cpu=250000000L
datanoisetv_picoadk_v2.menu.freq.275=275 MHz
datanoisetv_picoadk_v2.menu.freq.275.build.f_cpu=275000000L
datanoisetv_picoadk_v2.menu.freq.300=300 MHz
datanoisetv_picoadk_v2.menu.freq.300.build.f_cpu=300000000L
datanoisetv_picoadk_v2.menu.freq.150=150 MHz
datanoisetv_picoadk_v2.menu.freq.150.build.f_cpu=150000000L
datanoisetv_picoadk_v2.menu.freq.50=50 MHz
Expand Down
3 changes: 1 addition & 2 deletions tools/json/datanoisetv_picoadk_v2.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,7 @@
"jlink",
"raspberrypi-swd",
"picotool",
"picoprobe",
"pico-debug"
"picoprobe"
]
},
"url": "https://www.raspberrypi.org/products/raspberry-pi-pico/",
Expand Down
5 changes: 4 additions & 1 deletion tools/makeboards.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,10 @@ def MakeBoard(name, chip, vendor_name, product_name, vid, pid, pwr, boarddefine,
BuildFlashMenu(name, chip, 8*1024*1024, [0, 7*1024*1024, 4*1024*1024, 2*1024*1024])
BuildFlashMenu(name, chip, 16*1024*1024, [0, 15*1024*1024, 14*1024*1024, 12*1024*1024, 8*1024*1024, 4*1024*1024, 2*1024*1024])
elif name == "datanoisetv_picoadk_v2":
BuildPSRAM(name)
BuildPSRAM(name)
BuildPSRAMCS(name)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BukldPSRAMCS, BuildPSRAMFREQ, and BuildFreq aren't needed here. You have a hard-wired board and know the CS pin (which should be a #define PSRAM_CS xxx in variants/datanoisetv_v2/pins_arduino.h). There's no reason to have these as a menu. Only the first PSRAM size via buildpsram is needed here. See the challenger_2350_bconnect or other RP2350 board w/PSRAM for more info...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I should just leave BuildPSRAM? Could you check the latest commit and maybe make necessary changes if possible? I am currently working on some example code.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If your board always has PSRAM then there's no need for these menus. Define the proper pin/clock/CS in the variant.h like in the other 2350+PSRAM boards and it will "just work."

If there are 2 boards, 1 with and 1 without, then only the BuildPSRAM menu makes sense to have because everything else if defined by the PCB.

BuildFreq is called 3 lines below, so the instance here is duplicate That's not legal and I'm not sure what the IDE will do in that case. Best case you end up with some weird dup's menu items.

BuildPSRAMFreq(name)
BuildFreq(name, 400)
else:
BuildFlashMenu(name, chip, flashsizemb * 1024 * 1024, fssizelist)
if chip == "rp2350":
Expand Down