Skip to content

Fixes Issue 2584: delays LRCK to falling edge of BCK in I2S input #2592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 9, 2024
Merged

Fixes Issue 2584: delays LRCK to falling edge of BCK in I2S input #2592

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6ac2978
Update pio_i2s.pio
JimMacA Nov 8, 2024
3f243f4
Update pio_i2s.pio.h
JimMacA Nov 8, 2024
e8a2d46
Update pio_i2s.pio
JimMacA Nov 9, 2024
e9e3414
Update pio_i2s.pio.h
JimMacA Nov 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions libraries/I2S/src/pio_i2s.pio
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,13 +162,13 @@ right1:
left1:
in pins, 1 side 0b01
jmp x--, left1 side 0b00
in pins, 1 side 0b11 ; Last bit of left has WCLK change per I2S spec

in pins, 1 side 0b01 ; 2584 LRCK stays low until BCLK goes low
; Last bit of left has WCLK change per I2S spec
mov x, y side 0b10
right1:
in pins, 1 side 0b11
jmp x--, right1 side 0b10
in pins, 1 side 0b01 ; Last bit of right also has WCLK change
in pins, 1 side 0b11 ; 2584 LRCK stays high until BCLK goes low
; Loop back to beginning...


Expand All @@ -184,13 +184,13 @@ right1:
left1:
in pins, 1 side 0b10
jmp x--, left1 side 0b00
in pins, 1 side 0b11 ; Last bit of left has WCLK change per I2S spec
in pins, 1 side 0b10 ;2584 LRCK stays low until BCLK goes low

mov x, y side 0b01
right1:
in pins, 1 side 0b11
jmp x--, right1 side 0b01
in pins, 1 side 0b10 ; Last bit of right also has WCLK change
in pins, 1 side 0b11 ; 2584 LRCK stays high until BCLK goes low
; Loop back to beginning...


Expand Down
8 changes: 4 additions & 4 deletions libraries/I2S/src/pio_i2s.pio.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,11 +286,11 @@ static const uint16_t pio_i2s_in_program_instructions[] = {
0xa022, // 0: mov x, y side 0
0x4801, // 1: in pins, 1 side 1
0x0041, // 2: jmp x--, 1 side 0
0x5801, // 3: in pins, 1 side 3
0x4801, // 3: in pins, 1 side 1
0xb022, // 4: mov x, y side 2
0x5801, // 5: in pins, 1 side 3
0x1045, // 6: jmp x--, 5 side 2
0x4801, // 7: in pins, 1 side 1
0x5801, // 7: in pins, 1 side 3
// .wrap
};

Expand Down Expand Up @@ -326,11 +326,11 @@ static const uint16_t pio_i2s_in_swap_program_instructions[] = {
0xa022, // 0: mov x, y side 0
0x5001, // 1: in pins, 1 side 2
0x0041, // 2: jmp x--, 1 side 0
0x5801, // 3: in pins, 1 side 3
0x5001, // 3: in pins, 1 side 2
0xa822, // 4: mov x, y side 1
0x5801, // 5: in pins, 1 side 3
0x0845, // 6: jmp x--, 5 side 1
0x5001, // 7: in pins, 1 side 2
0x5801, // 7: in pins, 1 side 3
// .wrap
};

Expand Down
Loading