Skip to content

SimpleMDNS: let begin return a bool #2599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 11, 2024
Merged

SimpleMDNS: let begin return a bool #2599

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
337cf1b
SimpleMDNS: let `begin` return a bool
GUVWAF Nov 11, 2024
850e93f
astyle
earlephilhower Nov 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions libraries/SimpleMDNS/src/SimpleMDNS.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,9 @@
#include <LwipEthernet.h>
#include <lwip/apps/mdns.h>

void SimpleMDNS::begin(const char *hostname, unsigned int ttl) {
bool SimpleMDNS::begin(const char *hostname, unsigned int ttl) {
if (_running) {
return;
return false;
}
mdns_resp_init();
struct netif *n = netif_list;
Expand All @@ -37,6 +37,8 @@ void SimpleMDNS::begin(const char *hostname, unsigned int ttl) {
__setStateChangeCallback(_statusCB);
_hostname = strdup(hostname);
_running = true;

return true;
}

void SimpleMDNS::enableArduino(unsigned int port, bool passwd) {
Expand Down
2 changes: 1 addition & 1 deletion libraries/SimpleMDNS/src/SimpleMDNS.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
class SimpleMDNS {

public:
void begin(const char *hostname, unsigned int ttl = 60);
bool begin(const char *hostname, unsigned int ttl = 60);
void enableArduino(unsigned int port, bool passwd = false);
void addService(const char *service, const char *proto, unsigned int port);

Expand Down
Loading