lwip_wrap.h: wrap more functions#3372
Open
functionpointer wants to merge 2 commits intoearlephilhower:masterfrom
Open
lwip_wrap.h: wrap more functions#3372functionpointer wants to merge 2 commits intoearlephilhower:masterfrom
functionpointer wants to merge 2 commits intoearlephilhower:masterfrom
Conversation
Nonwrapped functions were found by implementing LWIP_ASSERT_CORE_LOCKED
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While debugging #3265 i have found several LWIP functions that were called without the mutex being held. This was found by implementing
LWIP_ASSERT_CORE_LOCKEDwithasync_context_lock_check(__getEthernetContext());This PR wraps these functions to ensure integrity of LWIP.
Additionally, it adds a comment about async context behaviour that explains some behavior seen in #1973, #1864 and #1979