Closed
Conversation
This change: dcbd543 after zarr-developers/zarr-python#3304 we need to be specific about if we have V2 or V3 arrays
Collaborator
|
Did a strict backport not work? I think that some of the extra things in the original were important to avoid the real failures here. |
Collaborator
Author
|
@ianhi I don't think I missed anything from the original commit |
ianhi
reviewed
Nov 28, 2025
| *, | ||
| sources: list[Array], | ||
| targets: list[zarr.Array], | ||
| targets: list[zarr.Array[ArrayV3Metadata]], |
Collaborator
There was a problem hiding this comment.
in #1433 this, and others, are wrapped in quotes to avoid the import failures
Collaborator
Author
There was a problem hiding this comment.
that's weird ... i didn't do this manually. Anyway, I can try this, thank you!
Collaborator
Author
|
@ianhi did it better |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change: dcbd543
after zarr-developers/zarr-python#3304 we need to be specific about if we have V2 or V3 arrays