Conversation
…an/add-cxx-band-fluxes Add band-by-band fluxes for C++ version
Add missing computation for net band-by-band fluxes. A previous PR added the FluxesByband class to keep track of spectral fluxes, but we neglected to properly set the resulting net fluxes (only the up and down). This also adds a test to the allsky test code to make sure that the sum of the computed byband fluxes matches the sum of the broadband fluxes as a sanity check. [BFB]
…an/fix-cxx-net-flux Add computation for net band-by-band fluxes
…nger/pass_dims Make ncol/nlay inputs at various places
…cdf_fixes CMake NetCDF fixes
…an/build-as-library Enable building RRTMGPXX as a library with CUDA
…/FPE_fix Fix potential floating point exception when tau = 0
Allocate 1 item at a time to ensure aligned memory.
…a/more_perf These changes get kokkos+rrtmgp performance on frontier to match yakl+rrtmgp
…8/disable-info-end-printouts disable printing verbose warnings at end of runtime
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just opening this as a longterm goal.