Avoid underflow at initialization#385
Open
dustinswales wants to merge 3 commits intoearth-system-radiation:mainfrom
Open
Avoid underflow at initialization#385dustinswales wants to merge 3 commits intoearth-system-radiation:mainfrom
dustinswales wants to merge 3 commits intoearth-system-radiation:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CCPP recently updated tom using rte-rrtmgp v1.8 and we encounter the following compilation warning in the UFS Weather Model:
RRTMGP/rte-rrtmgp/rte-frontend/mo_rte_lw.F90(137): warning #7920: The value was too small when converting to REAL(KIND=4); the result is in the denormalized range.
gauss_Ds = 1._wp / &
This PR breaks the declaration into two steps to avoid dividing by a really huuge number.
More discussion can be found here.
@RobertPincus For some reason I can't edit the PR title, nor did I create this title. ?!?