Skip to content

Reduce flakiness of Check Links CI job#1257

Merged
mfisher87 merged 1 commit intomainfrom
reduce-flakiness-of-check-links
Mar 11, 2026
Merged

Reduce flakiness of Check Links CI job#1257
mfisher87 merged 1 commit intomainfrom
reduce-flakiness-of-check-links

Conversation

@mfisher87
Copy link
Member

@mfisher87 mfisher87 commented Mar 10, 2026

Description

GitHub's unauthenticated rate limits make it impractical to check GitHub links. Link checks are regularly failing for 429 responses from GH.

This reduces the value of this job, but it also speeds it up 🤷 It's still going to catch other broken links.

See: #1254 (comment)

At the time it errored on https://www.gnu.org/software/inetutils/manual/html_node/The-_002enetrc-file.html, and the link really was broken. But it's back up now. So I guess that's just another example of this job being flaky, for reasons out of our control 🤷


"Ready for review" checklist

  • Open PR as draft
  • Please review our Pull Request Guide
  • Mark "ready for review" after following instructions in the guide

Merge checklist

  • PR title is descriptive
  • PR body contains links to related and resolved issues (e.g. closes #1)
  • If needed, CHANGELOG.md updated
  • If needed, docs and/or README.md updated
  • If needed, unit tests added
  • All checks passing (comment pre-commit.ci autofix if pre-commit is failing)
  • At least one approval

📚 Documentation preview 📚: https://earthaccess--1257.org.readthedocs.build/en/1257/

GitHub's rate limits make this impractical. Link checks are regularly
failing for 429 responses from GH.
@github-actions
Copy link

Binder 👈 Launch a binder notebook on this branch for commit 199c6aa

I will automatically update this comment whenever this PR is modified

@danielfromearth danielfromearth added the impact: automation CI, CD, or other automation label Mar 11, 2026
@mfisher87 mfisher87 merged commit e27b16e into main Mar 11, 2026
10 checks passed
@mfisher87 mfisher87 deleted the reduce-flakiness-of-check-links branch March 11, 2026 16:00
@mfisher87
Copy link
Member Author

Thanks for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

impact: automation CI, CD, or other automation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants