[Snyk] Security upgrade eslint from 8.11.0 to 9.0.0#44
[Snyk] Security upgrade eslint from 8.11.0 to 9.0.0#44earthiverse wants to merge 1 commit intomainfrom
Conversation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-JSYAML-13961110
Summary of ChangesHello @earthiverse, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request, automatically generated by Snyk, aims to enhance the project's security posture by upgrading the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This PR upgrades ESLint to v9 to fix a security vulnerability. This is a major version upgrade with significant breaking changes. I've identified two critical issues that must be addressed for your project to continue working: the required Node.js version has been increased, and the @typescript-eslint packages are now incompatible and must be upgraded. I've provided suggestions to resolve these. Please review the changes and my comments carefully before merging.
| "@typescript-eslint/parser": "^5.16.0", | ||
| "copyfiles": "^2.4.1", | ||
| "eslint": "^8.11.0", | ||
| "eslint": "^9.0.0", |
There was a problem hiding this comment.
Upgrading ESLint to v9 is a major change with several breaking changes and important considerations:
-
@typescript-eslintIncompatibility (Critical): The current versions of@typescript-eslint/eslint-plugin(line 34) and@typescript-eslint/parser(line 35) are not compatible with ESLint v9. They must be upgraded to v7.x or newer. Without this, linting TypeScript files will fail. You'll need to update yourpackage.jsonlike this:"@typescript-eslint/eslint-plugin": "^7.0.0", "@typescript-eslint/parser": "^7.0.0",
-
Node.js Version Requirement (Critical): ESLint v9 and its dependencies require Node.js
^18.18.0,^20.9.0, or>=21.1.0. Your development and CI/CD environments must be updated to a compatible Node.js version to prevent build failures. I recommend adding anenginesfield to yourpackage.jsonto document this requirement:"engines": { "node": ">=18.18.0" }
-
Configuration & Rule Changes (Medium): ESLint v9 is transitioning to a new "flat config" system (
eslint.config.js). While your existing.eslintrcfile should still work, some rules have been removed from the core or changed. A thorough test of your linting setup is advisable after this upgrade. -
Deprecated Dependencies (Medium): This upgrade pulls in newer versions of
@humanwhocodes/config-arrayand@humanwhocodes/object-schema, which are now marked as deprecated. Consider planning a migration to their replacements (@eslint/config-arrayand@eslint/object-schema) in a future update.
Snyk has created this PR to fix 1 vulnerabilities in the npm dependencies of this project.
Snyk changed the following file(s):
package.jsonpackage-lock.jsonVulnerabilities that will be fixed with an upgrade:
SNYK-JS-JSYAML-13961110
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Prototype Pollution