Open
Conversation
merging USD and other new changes into CROMA
mpomarlan
reviewed
May 16, 2025
| <owl:Class rdf:about="http://www.ease-crc.org/ont/CROMA.owl#CRAM_Designator"> | ||
| <rdfs:subClassOf rdf:resource="http://www.ease-crc.org/ont/CROMA.owl#Designator"/> | ||
| <rdfs:subClassOf> | ||
| <owl:Restriction> |
Collaborator
There was a problem hiding this comment.
This restriction should say that a CRAM designator is resolved_to only a CRAM designator. Not all designators are resolved, but those that are can only be resolved to designators.
Collaborator
|
Would be nice to add some axioms about the resolved_to/_from relations, specifically stuff like action designator resolved being resolved_from only action designator description (or whatever the least resolved one is), and action designator performed being resolved_from only action designator resolved. If there are some other types of designator description / resolved pairs, similar axioms should be there as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a draft version of CROMA.owl, which is supposed to represent CRAM-Designators and connect them to SOMA. Please feel free to move the newly added classes to other subclasses (I wasn't sure about where they should go but just wanted all the classes to exist already) or notify me if anything is unclear.
Let me know if I forgot to add annotations to things.