Open
Conversation
Defined `statusClientClosedRequest` constant in `pkg/filters/proxies/httpproxy/pool.go` and replaced the hardcoded 499 usage with it. This addresses the TODO comment. Co-authored-by: LokiWager <32408858+LokiWager@users.noreply.github.com>
…63240835599583949 Define constant for status code 499
There was a problem hiding this comment.
Pull request overview
Defines a named constant for HTTP status code 499 (“Client Closed Request”) and replaces the inline numeric literal usage in the server pool error path.
Changes:
- Added
statusClientClosedRequestconstant (499) inpool.go. - Replaced hardcoded
499in the client-disconnect error return with the constant.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Defined
statusClientClosedRequestconstant inpkg/filters/proxies/httpproxy/pool.goand replaced the hardcoded 499 usage with it.