Optimize Access Log and MQTT Session Paths#1502
Merged
xxx7xxxx merged 3 commits intoeasegress-io:mainfrom Feb 28, 2026
Merged
Conversation
Co-authored-by: LokiWager <32408858+LokiWager@users.noreply.github.com>
Replaced redundant time.Now() calls with the time value received from ticker.C in the background session task loop. This reduces syscall overhead. Verified with microbenchmarks (~2.5x speedup in loop overhead). Co-authored-by: LokiWager <32408858+LokiWager@users.noreply.github.com>
- Added `sessionCache` and `sortedSessionKeys` to `Broker`. - Initialized and updated cache via `connectWatcher` and `processWatcherEvent`. - Rewrote `queryAllSessions` to use cached sorted keys for efficient pagination. - Updated `httpGetAllSessionHandler` to use the cache instead of fetching all sessions from store. - Replaced random map iteration with deterministic sorted slice iteration. Co-authored-by: LokiWager <32408858+LokiWager@users.noreply.github.com>
xxx7xxxx
approved these changes
Feb 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR combines three performance optimizations:
pkg/object/httpserver/mux.go)pkg/object/mqttproxy/session.go)ticker.Cinstead of repeatedtime.Now()calls in the background loop.pkg/object/mqttproxy/broker.go)Broker(map + sorted key slice).Why
The previous implementation had repeated compute/system-call overhead and O(N) storage/CPU cost in hot paths:
time.Now()calls in high-frequency loopThis PR reduces those costs while preserving behavior.
Measured Improvements (from original PR benchmarks)
Access log formatter:
MQTT session loop:
MQTT session pagination:
getPrefixcall per list requestSafety / Compatibility