Skip to content

adopt module_load_environment in imkl-FFTW easyblock#3612

Merged
boegel merged 1 commit intoeasybuilders:5.0.xfrom
lexming:modload-imklfftw
Feb 18, 2025
Merged

adopt module_load_environment in imkl-FFTW easyblock#3612
boegel merged 1 commit intoeasybuilders:5.0.xfrom
lexming:modload-imklfftw

Conversation

@lexming
Copy link
Contributor

@lexming lexming commented Feb 17, 2025

Update of imkl-FFTW easyblock for #3527

@lexming lexming added the EasyBuild-5.0 EasyBuild 5.0 label Feb 17, 2025
@lexming lexming added this to the 5.0 milestone Feb 17, 2025
@lexming
Copy link
Contributor Author

lexming commented Feb 17, 2025

Test report by @lexming

Overview of tested easyconfigs (in order)

  • SUCCESS imkl-FFTW-2022.1.0-iimpi-2022a.eb
  • SUCCESS imkl-FFTW-2023.1.0-iimpi-2023a.eb
  • SUCCESS imkl-FFTW-2024.2.0-iimpi-2024a.eb

Build succeeded for 3 out of 3 (3 easyconfigs in total)
login1.cerberus.os - Linux Rocky Linux 8.10, x86_64, Intel(R) Xeon(R) Gold 6126 CPU @ 2.60GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/lexming/6b3ee1f9742089dc2adaec7cccb527e6 for a full test report.

@boegel boegel changed the title adopt module_load_environment in imkl-fftw easyblock adopt module_load_environment in imkl-FFTW easyblock Feb 17, 2025
@boegel boegel added the change label Feb 17, 2025
@boegel
Copy link
Member

boegel commented Feb 18, 2025

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS imkl-FFTW-2022.2.1-iompi-2022b.eb
  • SUCCESS imkl-FFTW-2024.2.0-iimpi-2024a.eb
  • SUCCESS imkl-FFTW-2023.2.0-iimpi-2023b.eb

Build succeeded for 3 out of 3 (3 easyconfigs in total)
node3514.doduo.os - Linux RHEL 8.8, x86_64, AMD EPYC 7552 48-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/boegel/8a50b724b20176309a28bbea411dde04 for a full test report.

@boegel
Copy link
Member

boegel commented Feb 18, 2025

@lexming There are significant differences in the generated module file, doesn't look correct to me?

-prepend_path("CMAKE_PREFIX_PATH", pathJoin(root, "../../imkl/2023.2.0/mkl/2023.2.0"))
-prepend_path("CPATH", pathJoin(root, "../../imkl/2023.2.0/mkl/2023.2.0/include"))
-prepend_path("CPATH", pathJoin(root, "../../imkl/2023.2.0/mkl/2023.2.0/include/fftw"))
-prepend_path("FLEXIBLAS_LIBRARY_PATH", pathJoin(root, "../../imkl/2023.2.0/mkl/2023.2.0/lib/intel64/flexiblas"))
-prepend_path("LD_LIBRARY_PATH", pathJoin(root, "../../imkl/2023.2.0/mkl/2023.2.0/lib/intel64"))
-prepend_path("LIBRARY_PATH", pathJoin(root, "../../imkl/2023.2.0/mkl/2023.2.0/lib/intel64"))
-prepend_path("PKG_CONFIG_PATH", pathJoin(root, "../../imkl/2023.2.0/mkl/2023.2.0/lib/pkgconfig"))
+prepend_path("CMAKE_PREFIX_PATH", root)
+prepend_path("LD_LIBRARY_PATH", pathJoin(root, "lib"))
+prepend_path("LIBRARY_PATH", pathJoin(root, "lib"))

This is with latest imkl easyblock (as updated in #3555)

@lexming
Copy link
Contributor Author

lexming commented Feb 18, 2025

@boegel the paths in red are very wrong, that module of imkl-FFTW has paths pointing outside of its installation directory into the installation of imkl. I must say that I did not see such behaviour in my 5.0.x; but if this PR fixes such an issue on your side, that is very good.

Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel merged commit f1b6a85 into easybuilders:5.0.x Feb 18, 2025
19 checks passed
@lexming lexming deleted the modload-imklfftw branch February 18, 2025 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

No open projects
Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants