Skip to content

Show directory that was searched for source directory in Clang easyblock #3960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Show directory that was searched for source directory in Clang easyblock #3960

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions easybuild/easyblocks/c/clang.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,8 +258,8 @@ def find_source_dir(globpatterns, targetdir):

glob_src_dirs = [glob_dir for globpattern in globpatterns for glob_dir in glob.glob(globpattern)]
if len(glob_src_dirs) != 1:
raise EasyBuildError("Failed to find exactly one source directory for pattern %s: %s", globpatterns,
glob_src_dirs)
raise EasyBuildError("Failed to find exactly one source directory in %s for pattern %s: %s",
os.getcwd(), globpatterns, glob_src_dirs)
Copy link
Member

@boegel boegel Oct 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to worry about this directory potentially not existing?

If so, we can use os.getenv('PWD') instead of os.getcwd()?

Copy link
Contributor Author

@Flamefire Flamefire Oct 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see how it is possible for this directory to get removed while we are in the top of the extract step

src_dirs[glob_src_dirs[0]] = targetdir

if any([x['name'].startswith('llvm-project') for x in self.src]):
Expand Down