CI: Enable flake8-comprehension and fix issues #3989
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://pypi.org/project/flake8-comprehensions/ has various useful checks, most importantly:
I.e. things like any([expensive_check(x) for x in collection]) runs the check after processing the full collection instead of stopping after the first "match" which costs performance.
To me the whole collection of checks look useful for performance and readability so enable them all.
See easybuilders/easybuild-framework#5043
Requires:
runtime_onlyparam todependency_nameseasybuild-framework#5044 fordependency_name(runtime_only=True)I used as some issues involved emulating this function