-
Notifications
You must be signed in to change notification settings - Fork 310
Explictly call PythonPackage and Cargo configure step in CargoPythonPackage easyblock
#3996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explictly call PythonPackage and Cargo configure step in CargoPythonPackage easyblock
#3996
Conversation
That does additional configuration required for Rust crates
|
@Flamefire Can you clarify (in the PR description, and with a comment in the easyblock) why this is needed? |
|
It was "just missing". So the question worth a comment would rather by why it does not need to be this way. If we don't do this we only call the configure_step of PythonPackage, not of Cargo which isn't what we want, do we? IIRC how the Python MRO works we could always use Currently MRO will find |
PythonPackage and Cargo configure step in CargoPythonPackage easyblock
Currently only >>> class A():
... def test(self):
... print('A.test')
...
>>> class B():
... def test(self):
... print('B.test')
...
>>> class C(A,B):
... pass
...
>>> c=C()
>>> c.test()
A.testBut note that |
|
@Flamefire You are changing So then the changes being made here should be included in that PR. In isolation it just doesn't make much sense to me... |
#3995 did include this PR, although rather intended for easier testing as merging the PRs individually might be easier for drafting release notes. |
That does additional configuration required for Rust crates with #3995