-
Notifications
You must be signed in to change notification settings - Fork 310
enhance LLVM easyblock to fix tests not finding GCCcore libraries #4010
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… compiler config files for non-`full-llvm` installations
|
@boegelbot please test @ jsc-zen3 |
|
@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de PR test command '
Test results coming soon (I hope)... Details- notification for comment with ID 3625794430 processed Message to humans: this is just bookkeeping information for me, |
|
@boegelbot please test @ jsc-zen3 |
|
Test report by @boegelbot Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (total: 18 mins 11 secs) (1 easyconfigs in total) |
|
@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de PR test command '
Test results coming soon (I hope)... Details- notification for comment with ID 3625845564 processed Message to humans: this is just bookkeeping information for me, |
|
@boegelbot please test @ jsc-zen3 |
|
Also successfully tested in EESSI/software-layer#1318. |
|
@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de PR test command '
Test results coming soon (I hope)... Details- notification for comment with ID 3625933153 processed Message to humans: this is just bookkeeping information for me, |
|
Test report by @boegelbot Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (total: 2 hours 2 mins 42 secs) (1 easyconfigs in total) |
|
Test report by @boegelbot Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (total: 2 hours 51 mins 51 secs) (1 easyconfigs in total) |
boegel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Always add the
-Lpointing to the GCCcore libraries location in the compiler config files for non-full-llvminstallationsSEE EESSI/software-layer-scripts#115 (comment) for more details
Not 100% sure but i guess we did not hit this on the bot's newer LLVM builds as some system
-lstdc++and-lgcc_swhere being used for those tests that excludeLIBRARY_PATHfrom their environmentSince this is only adding redundancy, as we specify the location of the GCC libraries both through
LIBRARY_PATH(since adf3b83) and the-Lin the compiler config file) this should not cause any trouble