-
Notifications
You must be signed in to change notification settings - Fork 310
Ensure AmberTools will find the correct python library and include dir #4045
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
| version = get_software_version('Python') | ||
| shlib_ext = get_shared_lib_ext() | ||
| self.cfg.update('configopts', '-DDOWNLOAD_MINICONDA=FALSE') | ||
| self.cfg.update('configopts', '-DPYTHON_EXECUTABLE=%s' % os.path.join(pythonroot, 'bin', 'python')) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed as this is now set by the CMake configure_step
|
@boegelbot please test @ jsc-zen3 |
|
@Crivella: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de PR test command '
Test results coming soon (I hope)... Details- notification for comment with ID 3777460910 processed Message to humans: this is just bookkeeping information for me, |
|
Test report by @boegelbot Overview of tested easyconfigs (in order)
Build succeeded for 0 out of 3 (total: 3 mins 53 secs) (3 easyconfigs in total) NOTES🫤 |
I proposed easybuilders/easybuild-easyconfigs#23747 last time that site was down and also to allow fully offline builds. See also #3900 and #3901 |
|
@boegelbot please test @ jsc-zen3 |
|
@Crivella: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de PR test command '
Test results coming soon (I hope)... Details- notification for comment with ID 3784582058 processed Message to humans: this is just bookkeeping information for me, |
|
Test report by @boegelbot Overview of tested easyconfigs (in order)
Build succeeded for 3 out of 3 (total: 5 hours 20 mins 42 secs) (3 easyconfigs in total) |
Addresses failure of building
AmberToolson EESSIAmberTools uses
find_package(PythonLibs)which has been deprecated (require different hints than the one we currently set for python in CMake).With this changes we provide the dedicated hints for it to find the correct library and include directory.