BinariesTarball

[valtandor]

Removal of inconsistent execute permissions on certain EasyBlocks, and addition of functionality to BinariesTarball so that it can take a list of binaries (assuming that, sometimes, not everything in start_dir is required to be copied).

[hpcugentbot]

Automatic reply from Jenkins: Can I test this?

[boegel]

Jenkins: ok to test

[boegel]

@wpoely86: please review?

[hpcugentbot]

Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1317/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

[wpoely86]

lgtm

[boegel]

keep this on a single line, since it's really one entry (not three)

[boegel]

Some small remarks, looks OK overall.

It would be great to have a testcase for this before merging it in (easybuilders/easybuild-easyconfigs#2084 requires this, but is still WIP).

[hpcugentbot]

Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1321/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

[hpcugentbot]

Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1323/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

[valtandor]

@boegel: Regarding a test case for this EasyBlock, it's a curious one, given that (so far as I can tell) it's not actually used by any EasyConfigs or other EasyBlocks. Any test case would therefore have to be specially written. I'm sure we could do that between us, but I'm not sure how good a use of our time it would be.

[hpcugentbot]

Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1458/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

[hpcugentbot]

Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1509/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

[hpcugentbot]

Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1561/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

[hpcugentbot]

Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1585/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

[hpcugentbot]

Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1689/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

[hpcugentbot]

Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1704/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

[hpcugentbot]

Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1839/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

[hpcugentbot]

Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1847/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

[valtandor]

@boegel What do you think - develop a test case for this, or drop the PR and the branch? I'm inclined to the latter if there's no particular use case for it.