-
Notifications
You must be signed in to change notification settings - Fork 773
Avoid librsvg build writing to $HOME #24995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Avoid librsvg build writing to $HOME #24995
Conversation
I think going the Framework route is the most sensible option to be honest. Having lots of EasyBlocks just for each build combination of Cargo + X sounds like a nightmare to maintain. We've had a bit of a discussion back in #23907 (comment). |
|
@boegelbot please test @ jsc-zen3 |
|
Test report by @Flamefire |
|
@Thyre: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de PR test command '
Test results coming soon (I hope)... Details- notification for comment with ID 3709858368 processed Message to humans: this is just bookkeeping information for me, |
|
Test report by @boegelbot |
@boegel Shall we put that on the agenda for the next confcall to discuss? Being that early in the release cycle doing that change sooner than later gives us time to shake out any issues |
|
note i also made unrelated changes to latest librsvg in #24991 |
|
Those shouldn't cause conflicts as it edits another place |
(created using
eb --new-pr)This software uses Rust/cargo which creates and uses
$HOME/.cargowhich we don't want. Set$CARGO_HOMEto avoid this.More general question: How do we want to handle Rust builds with build systems?
Here Meson uses
/build/librsvg/2.60.0/GCCcore-13.3.0/librsvg-2.60.0/meson/cargo_wrapper.py --cargo $EBROOTRUST/bin/cargowhich callscargoWe already have easyblocks like
CargoPythonPackage/Bundlewhich uses the standardpip installbut with Cargo-specific preparations. Now we would need the same: Standardninjabuild but with Cargo-specific preparationsLooks like we'd need to move that to framework and have a parameter for all easyconfigs to enable those preparations to avoid
CargoMesonNinjaand friends.