initial implementation of run function to replace run_cmd + run_cmd_qa#4284
initial implementation of run function to replace run_cmd + run_cmd_qa#4284ocaisa merged 10 commits intoeasybuilders:5.0.xfrom
run function to replace run_cmd + run_cmd_qa#4284Conversation
|
@branfosj Up for taking a look at this and providing some feedback? |
| def run(cmd, fail_on_error=True, split_stderr=False, stdin=None, | ||
| hidden=False, in_dry_run=False, work_dir=None, shell=True, | ||
| output_file=False, stream_output=False, asynchronous=False, | ||
| qa_patterns=None, qa_wait_patterns=None): |
There was a problem hiding this comment.
A more general comment than specifically applying here, is do we want to move to using a specific standard for what we expect for arguements and docstrings? Something standard that we can then enforce using flake8.
I ask here, as I think I'd prefer these in alphabetical order.
There was a problem hiding this comment.
I'm fine with putting the options in alphabetical order, but the order used now isn't random: the most used options are basically listed first, and they're more-or-less grouped by type of option (like the qa_* ones).
Let's get some output from others on this (@lexming?), and not block the PR over this, since this is trivial to change in a follow-up PR if we care strongly enough.
Is there a way to selectively enforce alphabetical ordering for particular functions with flake8?
There was a problem hiding this comment.
I'm inclined to keep this as is for now, as long as we make sure to make no assumptions about the order of named options when calling run, we can reorder things later here...
…to check trace output of run function
|
Fix for broken tests is available in #4306 |
boegel
changed the title
boegel
changed the title
run function to replace run_cmd + run_cmd_qa
ocaisa
left a comment
ocaisa
left a comment
There was a problem hiding this comment.
LGTM
Still a lot to go as regards implementation, but as long as the tests are there for each newly implemented option this should be fine.
Co-authored-by: ocaisa <alan.ocais@cecam.org>
4 participants
cfr. #4252
Marked as draft because:
runwith the current implementation;run_cmdtorunwhere possible;