-
Notifications
You must be signed in to change notification settings - Fork 220
change Toolchain.get_flag so it doesn't automatically prepend a dash (-) to compiler flags, add deprecation warning for optarch value without leading dash, rename Compiler.COMPILER*_FLAGS to Compiler.COMPILER*_OPTIONS
#4698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
2a6deae
Add dashes in front of compiler flags
Micket 66786ab
Drop adding - for compiler options in toolchain tests
Micket 46fd6d5
Drop extra dashes in front of compiler flags in tests
Micket be87ddd
Stop adding - in front of option flags
Micket 516d94b
Add - in front of compiler flags for yet more tests
Micket 771753b
Remove unnecessary list conversion
Micket 8a43c31
Drop now pointless test since get_flag is trivial
Micket d90e38f
Add - in front of another mcpu flag
Micket 72c41a6
Use StrList instead of *FlagList
Micket 1353f54
Adjusts test to not expect appending of - for flags
Micket cbdcbbf
Add dashes for shared compiler flags
Micket 6ae9912
Add test to check for old and new optarch syntax. Add deprecation war…
Micket 8f13bb3
Add missing - in front of mt_mpi
Micket 6e6f806
Rename several _FLAGS to _OPTIONS as that is what they actually are.
Micket cd3b614
Fix typo
Micket e16de3b
Fix typo
Micket d99d4ac
Correctly put dash in front of gencode instead of arch for CUDA
Micket 96acb98
Exclude cray when using optarch as a flag since it has it's own hacks.
Micket bd0f28d
Stop removing - from flags, use log.deprecated
Micket e52fad4
Add warnings for non EB 5.0 compliant compilers
Micket bac012a
Allow deprecated behaviour for "test" optarch flag
Micket 73f526c
Allow deprecation warnings when testing intelflag/gccflag
Micket 29ebf18
Fix typo that broke test
Micket d025e66
Fix faulty rebase
Micket a94f2b3
Revert removal of test_get_flag
Micket File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, do we really need to change this?
We have to take into account that people may have their own/custom implementations of classes that derive from
Compiler, they will need to be adjusted accordingly (and we have no easy way to produce a clean error message there, I think)...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A deprecation warning has been implemented by @Micket in
Compiler._set_compiler_flags, so this change won't cause any silent breakage.