show readable error message when applying patch without (extracted) source#4738
Merged
boegel merged 4 commits intoeasybuilders:developfrom Aug 27, 2025
Merged
show readable error message when applying patch without (extracted) source#4738boegel merged 4 commits intoeasybuilders:developfrom
boegel merged 4 commits intoeasybuilders:developfrom
Conversation
Member
|
@Flamefire Any idea why that one test keeps failing here? |
Contributor
Author
|
I think this is envmodules/modules#82 caused by running the extension step multiple times without resetting the environment. I hope the new commit fixes this. |
Contributor
Author
|
Yes that was the issue :) |
boegel
modified the milestones:
next release (5.0.1 or 5.1.0),
release after next release (5.0.1 or 5.1.0)
Flamefire
force-pushed
the
patch-error-msg
branch
from
10fd800 to
13b7bcd
Compare
Contributor
Author
|
Rebased |
Member
|
@Flamefire Test needs love? |
…ource When there is no source `self.src` is an empty list which leads to a rather generic error message. Improve that by showing that there was no source to apply the patch to. For extensions `self.src` is set to a string as only a single source is supported. Accessing `self.src[0].['finalpath']` leads to an error > TypeError: string indices must be integers This happens when the source didn't got extracted so `self.ext_dir` and hence `beginpath` will be `None`. Make the error show that the source was not extracted.
Flamefire
force-pushed
the
patch-error-msg
branch
from
814428f to
c93e7c3
Compare
Contributor
Author
|
Rebased and fixed. The test easyblock used a generic signature. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When there is no source
self.srcis an empty list which leads to a rather generic error message. Improve that by showing that there was no source to apply the patch to.For extensions
self.srcis set to a string as only a single source is supported.Accessing
self.src[0].['finalpath']leads to an errorWhile doing that get rid of
patch['source']which can never be set as it would trigger a failure increate_patch_infoas it isn't specified as an allowed key. It isn't useful anyway as only the first source will have itsfinalpathset correctly, the other, when unpacked to the same folder, are just referring to that folder instead of their subfolder.