Small improvements to ModuleLoadEnvironment#4754
Merged
boegel merged 3 commits intoeasybuilders:5.0.xfrom Feb 5, 2025
Merged
Conversation
Automatically do the detection if not done yet to avoid forgetting it.
Contributor
|
@Flamefire yeah, those make perfect sense, thanks for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I just checked #4653 and found a few possible improvements:
self.install_lib_symlink == LibSymlink.LIB64_TO_LIBmight silently fail if it is forgotten. Use a property with auto-init insteaddef __init__(... var_type=ModEnvVarType.PATH_WITH_FILES...)clearer in what the default is instead of using and checking forNone?for attr in self.__dict__: yield attr, getattr(self, attr)can be made simpler and faster by usingyield from self.__dict__.items()or just returning the latterenvironcan use a dict-comprehension for brevity and speed to avoid repeatedupdatecallsDo those make sense? @lexming @boegel