enable non-blocking reads for streaming outputs#4755
enable non-blocking reads for streaming outputs#4755boegel merged 7 commits intoeasybuilders:5.0.xfrom
Conversation
|
@branfosj do not merge yet, there is a minor issue to fix. Now the output looks like:
|
|
@branfosj if all test pas, this is ready. Now the debug logs are properly formatted:
|
badd1f6 to
95a41d6
Compare
|
On a side note, this PR also removes the following print message: AFAICT this is a leftover from 4.9 that does not align with the behavior of |
…reads on input/output channels
This fixes an issue with EB5 on our cluster, running installs with
--logtostdouthangs after executing/usr/share/lmod/lmod/libexec/lmod python --terse --show-hidden availin the early stages. However, same installs without--logtostdoutgo fine. An manually executing thatlmodcommand also works fine.Issue seems to be with long/slow commands in streaming mode. The reading action on the output hinders the completion of the command. This PR enables read in non-blocking mode to avoid this issue.
Changelog:
readline: this does not change functionality as 128 bytes is a (longish) line and this improves readability of logs