hide output of module commands in log file by default + add --debug-module-cmds option to opt-in to keeping them#5045
Merged
Crivella merged 6 commits intoeasybuilders:developfrom Feb 23, 2026
Conversation
Flamefire
force-pushed
the
silent-module-cmd
branch
from
e97c36a to
bc81621
Compare
Member
|
@Flamefire merge conflict to resolve... |
Flamefire
force-pushed
the
silent-module-cmd
branch
from
7305f38 to
f3a12a2
Compare
Contributor
Author
|
Looks like I identified and fixed the same bug in the tests in multiple occasions. Rebased |
Flamefire
force-pushed
the
silent-module-cmd
branch
from
f3a12a2 to
e93ec4f
Compare
Flamefire
force-pushed
the
silent-module-cmd
branch
3 times, most recently
from
e7488a2 to
549c4ec
Compare
This is disabled by default and hides the output of the module command. That is usually just "noise" hiding the relevant part of the log. With it disabled the output looks like: > == 2025-11-14 10:58:31,197 run.py:511 INFO Running shell command '/opt/lmod/lmod/libexec/lmod python load GCC/4.6.3' in /git/easybuild-framework > == 2025-11-14 10:58:31,261 run.py:625 INFO Shell command completed successfully: /opt/lmod/lmod/libexec/lmod python load GCC/4.6.3
Flamefire
force-pushed
the
silent-module-cmd
branch
from
549c4ec to
ba87ed0
Compare
Crivella
requested changes
Feb 20, 2026
Crivella
approved these changes
Feb 23, 2026
Contributor
Crivella
left a comment
Crivella
left a comment
There was a problem hiding this comment.
LGTM
- Fix bug in usage of
re.subwherere.Mwas being passed tocountinstead offlags(plus usage as positional arguments is deprecated since 3.13 ) - Re-naming of argument default value and logic properly
- allow to keep using old one and adds a deprecation warning for it
- keeps default behavior consistent with old one
- Does not affect any other place than what is touched here (
.unloadis always called without specifyinglog_changesthroughout the EB repositories)
- Add tests for checking that module logs are properly shown/hidden
Contributor
|
Going in, thanks @Flamefire! |
boegel
changed the title
--debug-module-cmds option--debug-module-cmds option to opt-in to keeping them
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is disabled by default and hides the output of the module command.
That is usually just "noise" hiding the relevant part of the log.
With it disabled the output looks like:
I added small refactorings and fixes I've seen:
re.sub('module use [...]', modtxt, re.M)was wrong: The 3rd parameter iscountnotflagsIncludes:
test_copy_ec_from_commit#5077