Skip to content

Add display() methods and support for tinytable#647

Merged
etiennebacher merged 19 commits intomainfrom
tinytable_support
Sep 8, 2025
Merged

Add display() methods and support for tinytable#647
etiennebacher merged 19 commits intomainfrom
tinytable_support

Conversation

@strengejacke
Copy link
Member

@strengejacke strengejacke commented Sep 7, 2025

  • add some tests

@strengejacke strengejacke requested a review from Copilot September 7, 2025 12:08
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for the tinytable package across multiple display methods and implements display() methods where missing. The changes focus on extending formatting options to include "tt" (tinytable) format alongside existing markdown and HTML formats.

  • Adds tinytable support to display() methods for distribution descriptions, data tabulation, and codebooks
  • Implements a new display() method for data_codebook objects
  • Updates backend detection logic to handle tinytable formatting across different output contexts

Reviewed Changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
tests/testthat/test-describe_distribution.R Adds test for tinytable format display
tests/testthat/test-data_tabulate.R Adds comprehensive tests for tinytable format in tabulation functions
tests/testthat/test-data_codebook.R Adds tests for tinytable format in codebook display
tests/testthat/_snaps/*.md Snapshot files for tinytable output validation
man/*.Rd Documentation updates for new display methods and format parameter
R/describe_distribution.R Updates display method to support tinytable backend
R/data_xtabulate.R Adds backend detection for tinytable support
R/data_tabulate.R Implements display method and backend detection utilities
R/data_codebook.R Implements display method and tinytable support
NEWS.md Documents new features
NAMESPACE Exports new display method
DESCRIPTION Adds tinytable dependency

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@codecov
Copy link

codecov bot commented Sep 7, 2025

Codecov Report

❌ Patch coverage is 93.10345% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.14%. Comparing base (9a624b1) to head (ea3a812).
⚠️ Report is 22 commits behind head on main.

Files with missing lines Patch % Lines
R/data_codebook.R 86.66% 2 Missing ⚠️
R/data_tabulate.R 95.23% 1 Missing ⚠️
R/describe_distribution.R 93.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #647      +/-   ##
==========================================
+ Coverage   91.73%   92.14%   +0.41%     
==========================================
  Files          76       76              
  Lines        6410     6519     +109     
==========================================
+ Hits         5880     6007     +127     
+ Misses        530      512      -18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@strengejacke strengejacke marked this pull request as ready for review September 7, 2025 13:03
@strengejacke
Copy link
Member Author

@etiennebacher We have improved the display() method throughout easystats, supporting tinytable now. This PR updates (or adds, if required) the display() methods to support format = "tt". Furthermore, the methods also appear in the docs.

Copy link
Member

@etiennebacher etiennebacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, just a few comments to address and then this can be merged.

@etiennebacher
Copy link
Member

Also there's some styling to fix apparently

strengejacke and others added 2 commits September 7, 2025 18:45
Co-authored-by: Etienne Bacher <52219252+etiennebacher@users.noreply.github.com>
@etiennebacher etiennebacher merged commit 3f35d37 into main Sep 8, 2025
25 checks passed
@etiennebacher etiennebacher deleted the tinytable_support branch September 8, 2025 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments