labelled + parameters leads to NA variable labels

R/format_parameters.R

@@ -444,10 +444,19 @@ format_parameters.parameters_model <- function(model, ...) {
     }
     resp <- insight::find_response(model, combine = FALSE)
     mf <- mf[, setdiff(colnames(mf), resp), drop = FALSE]
+    # we need data a 2nd time, to identify on-the-fly-factors
+    mf_data <- insight::get_data(model, source = "mf", verbose = FALSE)
+    factors <- attributes(mf_data)$factors
 
     # return variable labels, and for factors, add labels for each level
     lbs <- lapply(colnames(mf), function(i) {
       vec <- mf[[i]]
+      # if variable is not a factor, we check whether variable
+      # was converted to factor on-the-fly.
+      if (!is.factor(vec) && !is.null(factors) && i %in% factors) {
+        # if so, we need to convert to factor, to have "factor levels"
+        vec <- as.factor(vec)
+      }
       if (is.factor(vec)) {
         variable_label <- attr(vec, "label", exact = TRUE)
         value_labels <- names(attr(vec, "labels", exact = TRUE))
@@ -507,10 +516,21 @@ format_parameters.parameters_model <- function(model, ...) {
         for (i in names(interactions)) {
           # extract single coefficient names from interaction term
           out <- unlist(strsplit(i, ":", fixed = TRUE))
+          # for on-the-fly conversion of factors, the names of the factors can
+          # can also contain "factor()" or "as.factor()" - we need to remove these
+          if (any(grepl("(as\\.factor|factor|as\\.character)", out))) {
+            out_clean <- gsub(
+              "(as\\.factor|factor|as\\.character)\\((.*)\\)(.*)",
+              "\\2",
+              out
+            )
+          } else {
+            out_clean <- out
+          }
           # combine labels
           labs <- c(
             labs,
-            paste(sapply(out, function(l) pretty_labels[l]), collapse = " * ")
+            paste(sapply(out_clean, function(l) pretty_labels[l]), collapse = " * ")
           )
         }
         # add interaction terms to labels string

R/utils_model_parameters.R

@@ -4,7 +4,7 @@
 #'
 #' @keywords internal
 #' @noRd
 .add_model_parameters_attributes <- function(params,
                                              model,
                                              ci,
                                              exponentiate = FALSE,
@@ -215,7 +215,11 @@
   }
 
   # add parameters with value and variable
-  attr(params, "pretty_labels") <- .format_value_labels(params, model)
+  if (isFALSE(dot.arguments$pretty_names)) {
+    attr(params, "pretty_labels") <- params$Parameter
+  } else if (is.null(attr(params, "pretty_labels", exact = TRUE))) {
+    attr(params, "pretty_labels") <- .format_value_labels(params, model)
+  }
 
   row.names(params) <- NULL
   params
@@ -254,7 +258,7 @@
 #'
 #' @keywords internal
 #' @noRd
 .find_coefficient_type <- function(info, exponentiate, model = NULL) {
   # column name for coefficients
   coef_col <- "Coefficient"
   if (!is.null(model) && inherits(model, "emmGrid")) {