Skip to content

Prepare CRAN release #1167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
strengejacke merged 3 commits into from
Sep 11, 2025
Merged

Prepare CRAN release #1167

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
980717d
Prepare CRAN release
strengejacke Sep 10, 2025
60c79b0
fix
strengejacke Sep 10, 2025
e30010a
skip tets on CRAN
strengejacke Sep 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DESCRIPTION
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Type: Package
Package: parameters
Title: Processing of Model Parameters
Version: 0.28.1.2
Version: 0.28.2
Authors@R:
c(person(given = "Daniel",
family = "Lüdecke",
Expand Down
2 changes: 1 addition & 1 deletion NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# parameters (devel)
# parameters 0.28.2

## Bug fixes

Expand Down
7 changes: 7 additions & 0 deletions R/methods_marginaleffects.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,13 @@ model_parameters.marginaleffects <- function(
out <- insight::standardize_names(out, style = "easystats")
}

# edge case: for avg_comparisons() with custom hypothesis, "term" and "hypothesis"
# are identical columns, now both names "Parameter" - remove one
param_cols <- which(colnames(out) == "Parameter")
if (length(param_cols) > 1) {
out[param_cols[-1]] <- NULL
}

# in case data grid contained column names that are reserved words,
# rename those back now...
colnames(out) <- gsub("#####$", "", colnames(out))
Expand Down
1 change: 1 addition & 0 deletions tests/testthat/test-model_parameters.efa_cfa.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
test_that("efa-cfa", {
skip_if_not_installed("psych")
skip_if_not_installed("lavaan")
skip_on_cran()

efa <- psych::fa(attitude, nfactors = 3)
params <- parameters::model_parameters(efa)
Expand Down Expand Up @@ -61,7 +62,7 @@
))
expect_identical(c(ncol(x), nrow(x)), c(5L, 11L))

# x <- suppressWarnings(model_parameters(FactoMineR::FAMD(iris, ncp = 3, graph = FALSE), threshold = 0.2, sort = TRUE))

Check warning on line 65 in tests/testthat/test-model_parameters.efa_cfa.R

View workflow job for this annotation

GitHub Actions / lint-changed-files / lint-changed-files 

file=tests/testthat/test-model_parameters.efa_cfa.R,line=65,col=121,[line_length_linter] Lines should not be more than 120 characters. This line is 121 characters.
# expect_identical(c(ncol(x), nrow(x)), c(5L, 5L))
})

Expand Down
Loading