Skip to content

R2 incorrect for methods that use update(model, ~1) and have missing data#804

Merged
strengejacke merged 9 commits intomainfrom
strengejacke/issue803
Mar 21, 2025
Merged

R2 incorrect for methods that use update(model, ~1) and have missing data#804
strengejacke merged 9 commits intomainfrom
strengejacke/issue803

Conversation

@strengejacke
Copy link
Member

Fixes #803

@strengejacke
Copy link
Member Author

Tests in McFadden fail.
We need to extract data from env, not model frame, then filter for complete cases (only data for model predictors). passing model-frame to update() doesn't work with variables like y / 10 etc.

@strengejacke strengejacke merged commit 3886b63 into main Mar 21, 2025
17 of 33 checks passed
@strengejacke strengejacke deleted the strengejacke/issue803 branch March 21, 2025 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

R2 incorrect for methods that use update(model, ~1) and have missing data

1 participant