-
-
Notifications
You must be signed in to change notification settings - Fork 89
Feature: Experimental livekit #386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
defnull
wants to merge
9
commits into
master
Choose a base branch
from
feature-livekit
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This seems to run correctly on our infra, I can not test sip though at the moment. |
Collaborator
Author
|
SIP/Dialin does not work, and I cannot get it to work. But that's fine, it's not marked as ready by upstream anyway. |
03b0e7d to
e66c44d
Compare
Introduce variables to set ownership of SSL files
This should have the same (or even better) effect as restricting interfaces and can be achieved with already known information.
…lin. Dial-in does not actually work, this is just for preparation once it is ready to use upstream.
e66c44d to
40d6522
Compare
Collaborator
Author
|
Sorry for the delay, I was sitting on 40d6522 for a while, frustrated that I could not get dial-in to actually work. But the changes are still useful once upstream is ready for it. Merge to main? |
The ansible.posix collection was probably installed as a transitive dependency anyway, but ansible lint complains about it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #385 but with additional fixes and adjustments needed after BBB 3.0.7 was releases.