Skip to content

rollback connection in closeConnectionFully #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rbygrave merged 1 commit into from
Feb 27, 2025
Merged

rollback connection in closeConnectionFully #110

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions ebean-datasource/src/main/java/io/ebean/datasource/pool/PooledConnection.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,6 +254,17 @@ void closeConnectionFully(boolean logErrors) {
Log.warn("Error when closing connection Statements", ex);
}
}
try {
// DB2 (and some other DBMS) may have uncommitted changes and do not allow close
// so try to do a rollback.
if (!connection.getAutoCommit()) {
connection.rollback();
}
} catch (SQLException ex) {
if (logErrors) {
Log.warn("Could not perform rollback", ex);
}
}
try {
connection.close();
pool.dec();
Expand Down
Loading