Heartbeat should not reset, when pool is full #111
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We discovered an issue, when the connection pool is full, the heartbeat will reset the pool, although this is not necessary.
How to reproduce:
maxSizethat will hold the connection longer thanheartbeatfreq + waitTimeoutMillisThis PR changes, how heartbeat detects, if connection is valid.
ConnectionPoolExhaustedException extends SQLExceptionis thrownConnectionPoolExhaustedExceptionit will be ignored multiple times.We ignore this exception
heartbeatMaxPoolExhaustedCounttimes. Normally this is not needed, but if there are really leaking connections (e.g. forgot to close) we perform a reset, if this happened repeatetly