Better recovery after reset on high pool load #112
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an issue, if there is high load on the pool.
in the
obtainConnectionthere is code, that prefers "waitingThreads" with the next connection, that comes back in the pool.what can happen now:
maxSize=1) and we hold the connection, while the heartbeat runs, the heartbeat might reset the pool._obtainConnectionWaitLoopI've simplified the test, it might be, that this test is flaky now, but it better demonstrates the issue.
Without this fix, we have one successful execution (see first commit), after the fix, all executions are successful.