Close connections asynchroniously #114
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We observed on a network outage, that the pool needs a very long time to recover (up to 2 hours) or even dead locks.
We could not reproduce this exactly in a testcase, but we think, that
closeBusyConnectionsmust wait for locks hold in the connection or statements.A simple testcase is written for H2, where the thread holds a synchronized lock on the H2 connection. This avoids a proper shutdown of the pool
I would suggest to run closeConnectionFully in an async thread (with a timeout of 5 seconds), because you never know, if connection.close will block and locks up the whole application.