Skip to content

Feature: Add a MethodHandles.Lookup SPI #3535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rbygrave merged 5 commits into from
Feb 12, 2025
Merged

Feature: Add a MethodHandles.Lookup SPI #3535

rbygrave merged 5 commits into from
Feb 12, 2025
+107 −43

Conversation

@SentryMan
Copy link
Contributor

@SentryMan SentryMan commented Dec 20, 2024

  • Adds new SPI interface to retrieve MethodHandles.Lookup
  • Adds a new class to contain all the lookups by module name
  • replace reflective bean construction with MethodHandles

Part of #3531

rbygrave
rbygrave reviewed Feb 11, 2025
View reviewed changes
@SentryMan SentryMan force-pushed the feature/serviceload-lookup branch from 3a82285 to bf5513a Compare February 11, 2025 15:14
@rbygrave
Copy link
Member

rbygrave commented Feb 11, 2025

Ok, looks pretty good. Are you happy with it / no more expected changes?

@SentryMan
Copy link
Contributor Author

SentryMan commented Feb 11, 2025

I don't expect anything else

@rbygrave rbygrave added this to the 14.9.0 milestone Feb 12, 2025
@rbygrave rbygrave merged commit de81dfc into ebean-orm:master Feb 12, 2025
1 check passed
@SentryMan SentryMan deleted the feature/serviceload-lookup branch February 12, 2025 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rbygrave rbygrave rbygrave left review comments

Assignees

@SentryMan SentryMan

Labels

None yet

Projects

None yet

Milestone

14.9.0

Development

Successfully merging this pull request may close these issues.

2 participants

@SentryMan @rbygrave