#3564 Fix for nested transaction with batch-mode does not flush #3565
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
rbygrave
commented
Feb 13, 2025
rbygrave
commented
- Adds flush() into ScopeTrans.commitTransaction()
- Related fixes in DefaultServer execute() and executeCall() where it was performing extra unnecessary nesting on PersistenceException
…hing batch on commit
Update the test to show that we desire the nested transaction changes to be "visible" after a commit regardless of flushOnQuery etc
- Adds flush() into ScopeTrans.commitTransaction() - Related fixes in DefaultServer execute() and executeCall() where it was performing extra unnecessary nesting on PersistenceException
Member
Author
|
Are you happy with this PR @jonasPoehler ? |
Contributor
|
Yes, this looks good to me! Thank you for cleaning this up and the extensive explanation in #3564. We can just close my original PR and merge this instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.