Test: Final SVG generation fix - end-to-end test #23

ebembi-crdb · 2025-12-23T14:57:58Z

Summary

Testing the complete SQL diagram automation pipeline with fixes for HTML/SVG generation.

Changes

Fixed bazel output path detection to find HTML files in _bazel/bin
Added Railroad JAR setup to bazel output base
Updated artifact copying logic to properly detect and copy HTML files

Expected Results

✅ 313 BNF files generated
✅ 313 HTML/SVG files generated
✅ manifest.json shows correct counts
✅ Artifacts uploaded with all files
✅ PR created to generated-diagrams repo (if changes detected)

Testing

This PR triggers the docgen-diagrams-ci workflow to test the complete pipeline end-to-end.

This reuses the logic that was added to handle SET. The only difference is that RESET always drops the StorageParam element. Release note: None

Release note: none. Epic: none.

Picks up cockroachdb/go#8 Release note: none. Epic: none.

159160: intentresolver: skip TestIntentResolutionUnavailableRange under duress r=wenyihu6 a=arulajmani Closes cockroachdb#159050 Release note: None Co-authored-by: Arul Ajmani <arulajmani@gmail.com>

There have been a couple incidents recently where workloads running multi day / million statement txns cause sql stats to have unbounded memory growth. This is happening because SQL Stats are buffered by sessionID until a transaction commits, which causes the buffer to flush and the statement stats to be recorded in the SQL stats subsystem. When there is a long running transaction with many statements, we buffer is never flushed and continues to grow. To fix this, we have introduced a new "flush" event that forces the SQL stats ingester to flush sql stats in the current session, if a certain threshold is met. This threshold is currently set to the value of a new cluster setting: `sql.metrics.transaction_details.max_statement_stats`. If this threshold is met, the stats are automatically flushed. The side effect of this is that these stats will not have an associated transaction fingerprint id. This is because the transaction fingerprint id isn't finalized until a transaction is complete and we don't know the transaction fingerprint id at the time of this forced flush. There is also no way to "backfill" or set the transaction fingerprint id once the statement stat has been recorded to the SQL Stats subsystem. This commit also includes a change to the `SQLStatsIngester.flushBuffer` method to recording transaction stats when there are no statements stats in the buffer. This is the case when the buffer is being force flushed in the scenario mentioned above. Fixes: cockroachdb#158800 Epic: None Release note (bug fix): Addresses a bug with unbounded memory growth when long running transactions are contain many statements. In this case, the SQL Stats system will automatically flush these before the transaction commits. The side effect of this is that these statement statistics will no longer have an associated transaction fingerprint id.

Reverting this commit for now because randomized decommission is failing due to timeouts. We could change the code to retry only on throttled stores, but I need to dig deeper. I’m uncertain why these errors don’t fail the test immediately and instead cause long waits without this commit. I’ll investigate separately. Given this behaviour has been on releases for a while, reverting seems okay. This reverts commit 5d90692. Fixes: cockroachdb#157973

The TestCheckRestartSafe_Criticality test now wraps its expectations in a SucceedsSoon. We allow the TestCheckRestartSafe_Integration test to use DRPC. Flakiness can no longer be reproduced on gceworker. Resolves: cockroachdb#158790 Resolves: cockroachdb#155111 Epic: None Release note: None

158931: obs, kv, sql: add workloadID to profile tags r=tbg,jasonlmfong a=dhartunian We introduce `pkg/obs/workloadid` which defines a commond workloadID definition, subject to extensive future modification, that we can use to tag CPU profiles and execution trace regions. Currently, the workloadID is either a static value, or a statement fingerprint ID. Where appropriate, we've tagged CPU profiles with a workload identifier. When tracing is enabled, on a request, we will attempt to include the workloadID into the region tag in the execution trace. This path is a bit perf sensitive so we only want to incur the cost of allocating the extra string when we're already paying the cost of tracing. It is expected that the combination of statementb diagnostic bundle capture and execution tracing can then be cross-referenced. Epic: CRDB-55080 Resolves: CRDB-55928 Resolves: CRDB-55924 Release note: None 159113: kvcoord: optimize txn write buffer for read-only txns r=yuzefovich a=yuzefovich In the txn write buffer we need to merge the ScanResponse coming from the server with any overlapping writes that we've buffered. This requires us to allocate `respMerger.batchResponses` which is the "staging" area of the merged response. However, if we don't have any overlapping buffered writes, then we simply copy the server response into that staging area. This commit adds an optimization to avoid this extra copy in a special but common case when the buffer is empty (i.e. we're in a read-only txn). We could extend the optimization further but that is left as a TODO. Epic: None Release note: None Co-authored-by: David Hartunian <davidh@cockroachlabs.com> Co-authored-by: Yahor Yuzefovich <yahor@cockroachlabs.com>

Release note: none. Epic: none.

This adds the ability to dump the child metrics which was introduced in cockroachdb#158148. These child metrics are discovered in the tsdump through their unique resolution and a limit list of qualified metric names. Epic: CRDB-55079 Release: None

This reverts commit 0b2c0ce.

This commit hides the `sql.stats.canary_fraction` cluster setting and `canary_stats_mode` session variable since the canary statistics feature is not yet complete. The table storage parameter `sql_stats_canary_window` remains unchanged because its default value of 0 prevents it from appearing in SHOW CREATE TABLE output, which is the primary way users would discover this parameter outside of documentation. Fixes cockroachdb#159080 Release note: None

Previously, restore operations could end up generating schema jobs without session data. While most schema changes do not require this, schema changes with refresh materialized view require this field to be setup. To address this, this patch sets up a session data in the schema change job to prevent panics. Fixes: cockroachdb#156515 Release note (bug fix): Addressed a bug where schema changes could fail after a RESTORE due to missing session data.

This storage parameter is special, so this requires logic to use the pre-existing TableSchemaLocked element rather than the normal storage param element. As part of this, we partially revert bc3f228 and refactor the check to be a little simpler since we don't actually need to handle the mixed version case now. Release note: None

Fixes cockroachdb#159174 Release note (bug fix): The `ascii` built-in function now returns `0` when the input is the empty string instead of an error.

Epic: REL-3909 Resolves: CRDB-57502 Release note: None

…achdb#159100 cockroachdb#159120 cockroachdb#159165 158390: sql: support table storage params change in the declarative schema changer r=rafiss a=shghasemi ### sql: support table storage params change in the declarative schema changer Previously, storage parameters were set and reset using the legacy schema changer. With this change, setting most non-backfilling table storage params will use the declarative schema changer. Setting ttl-related params, schema_locked, and infer_rbr_region_col_using_constraint is not implemented yet. ### schemachanger: handle RESET storage param in declarative schema changer This reuses the logic that was added to handle SET. The only difference is that RESET always drops the StorageParam element. ### schemachanger: handle manual schema_locked setting in declarative This storage parameter is special, so this requires logic to use the pre-existing TableSchemaLocked element rather than the normal storage param element. As part of this, we partially revert bc3f228 and refactor the check to be a little simpler since we don't actually need to handle the mixed version case now. Epic CRDB-31281 Fixes cockroachdb#155990 Release note: None 159075: sqlstats: skip TestSQLStatsDiscardStatsOnFingerprintLimit under race r=dhartunian a=dhartunian Resolves: cockroachdb#158978 Epic: None Release note: None 159096: cli: skip some zip tests under deadlock r=dhartunian a=dhartunian Resolves: cockroachdb#158973 Resolves: cockroachdb#158375 Resolves: cockroachdb#158467 Resolves: cockroachdb#158437 Epic: None Release note: None 159100: azure: set default of cloudstorage.azure.try.timeout to 0 r=jeffswenson a=msbutler This setting was previously set to 1m to deflake the TestAzureFaultInjection unit test, but unfortunately this also led to production backup flakes in the azure backup roachtest. Instead of reenabling this setting, we should to teach the resuming reader to time out hanging reads (reference issue cockroachdb#159098) Epic: none Release note: none 159120: build: bump go fork SHA for runtime.Yield and goroutine profiles r=dt a=dt 159165: Revert "decommission: retry on errors for AllocatorCheckRange" r=wenyihu6 a=wenyihu6 **Revert "decommission: retry on errors for AllocatorCheckRange"** Reverting this commit for now because randomized decommission is failing due to timeouts. We could change the code to retry only on throttled stores, but I need to dig deeper. I’m uncertain why these errors don’t fail the test immediately and instead cause long waits without this commit. I’ll investigate separately. Given this behaviour has been on releases for a while, reverting seems okay. This reverts commit 5d90692. Fixes: cockroachdb#157973 --- **Revert "kv: add TestDecommissionPreCheckRetryThrottledStores"** This reverts commit 0b2c0ce. Fixes: cockroachdb#157973 Co-authored-by: Shadi Ghasemitaheri <shadi.ghasemitaheri@cockroachlabs.com> Co-authored-by: Rafi Shamim <rafi@cockroachlabs.com> Co-authored-by: David Hartunian <davidh@cockroachlabs.com> Co-authored-by: Michael Butler <butler@cockroachlabs.com> Co-authored-by: David Taylor <davidt@davidt.io> Co-authored-by: wenyihu6 <wenyi@cockroachlabs.com>

Recently we have been seeing the test "Wait_with_timeout" as flaky, so we will add it in the ignore list. Release note: None Fixes: cockroachdb#158495

…achdb#159169 158351: roachtest: kv with long-running writer r=stevendanna a=miraradeva This commit includes a new roachtest that measures the latency of read-only non-locking requests in the presence of a long-running write-only transaction. The test maximizes contention by using a zipfian distribution on a small set of keys. It runs two concurrent KV workloads: 1. Long-running low-priority write-only transactions (running one at a time). Each transaction writes 100 keys and commits. 2. Read-only requests at normal priority. When a read encounters an intent, it will push the transaction based on priority and resolve (rewrite) the intent. Measuring the latency of the reads will help expose their blocking behavior, which we expect to change with future improvements in intent resolution, latching and transaction pushing (all part of non-blocking reads work). Fixes: cockroachdb#158348 Release note: None 158716: pkg/cli: allow tsdump to also dump the labeled child metrics r=jasonlmfong a=jasonlmfong This adds the ability to dump the child metrics which was introduced in cockroachdb#158148. These child metrics are discovered in the tsdump through their unique resolution and a limit list of qualified metric names. Epic: CRDB-55079 Release: None 158967: util: fix unique test r=aerfrei a=Lloyd-Pottiger Fix one flaky test. Release note: none. Epic: none. 159169: server: deflake TestCheckRestartSafe tests r=shubhamdhama a=dhartunian The TestCheckRestartSafe_Criticality test now wraps its expectations in a SucceedsSoon. We allow the TestCheckRestartSafe_Integration test to use DRPC. Flakiness can no longer be reproduced on gceworker. Resolves: cockroachdb#158790 Resolves: cockroachdb#155111 Epic: None Release note: None Co-authored-by: Mira Radeva <mira@cockroachlabs.com> Co-authored-by: Jason Fong <jason.fong@cockroachlabs.com> Co-authored-by: Lloyd-Pottiger <yan1579196623@gmail.com> Co-authored-by: David Hartunian <davidh@cockroachlabs.com>

Use the fs.BatchEvalReadCategory in microbenchmarks. This category is used for the latency sensitive work we care about, and setting this category disables open iterator tracking. Epic: none Release note: none

Move this simple function to avoid a dependency cycle in an upcoming commit. Release note: None

Use the new (*testing.B).Loop helper where relevant to run b.N times, updating the timer to only measure the b.N iterations. Epic: none Release note: none

Use (*testing.B).Context instead of constructing a separate background context in the storage microbenchmarks. Epic: none Release note: none

The schemachanger previously attempted to predict whether a DROP COLUMN operation would fail due to a foreign key (FK) dependency. This logic has proven to be unreliable and difficult to maintain correctly. Rather than investing more effort into fixing the latest edge cases, we’ve decided to remove the FK dependency detection logic altogether. This simplifies the codebase. Resolves: cockroachdb#159034 Release note: none

159083: sql: hide canary stats settings pending feature completion r=ZhouXing19 a=ZhouXing19 This commit hides the `sql.stats.canary_fraction` cluster setting and `canary_stats_mode` session variable since the canary statistics feature is not yet complete. The table storage parameter `sql_stats_canary_window` remains unchanged because its default value of 0 prevents it from appearing in SHOW CREATE TABLE output, which is the primary way users would discover this parameter outside of documentation. Fixes cockroachdb#159080 Release note: None 159167: roachtest: deflake npgsql r=fqazi a=fqazi Recently we have been seeing the test "Wait_with_timeout" as flaky, so we will add it in the ignore list. Release note: None Fixes: cockroachdb#158495 159178: sql: ascii built-in should not error with an empty string r=mgartner a=mgartner Fixes cockroachdb#159174 Release note (bug fix): The `ascii` built-in function now returns `0` when the input is the empty string instead of an error. Co-authored-by: ZhouXing19 <zhouxing@uchicago.edu> Co-authored-by: Faizan Qazi <faizan@cockroachlabs.com> Co-authored-by: Marcus Gartner <marcus@cockroachlabs.com>

Generates a query id for sub statements executed in UDFs and SPs. This is used by the insights system to provide execution specific insights. Epic: None Release note: None

159057: besteffort: add besteffort utility r=jeffswenson a=jeffswenson This adds a package that can be used to mark blocks of code as best effort. This is intended to replace most instances of error logging in the dr codebase. Part of: cockroachdb#152677 Release note: none Co-authored-by: Jeff Swenson <jeffswenson@betterthannull.com>

In v25.4.0 we introduced an optimization for some types of generic query plans which converts parameterized lookup joins into placeholder scans. Prior to this commit the spans of these placeholder scans could contain scalar expressions that were not constants nor placeholders, which execbuilder does not support. This has been fixed by being more strict in the application of this rule. Fixes cockroachdb#159124 Release note (bug fix): A bug has been fixed which could cause prepared statements to fail with the error message "non-const expression" when they contained filters with stable functions. This bug has been present since 25.4.0.

159187: storage: small microbenchmark improvements r=jbowens a=jbowens **storage: use fs.BatchEvalReadCategory in benchmarks** Use the fs.BatchEvalReadCategory in microbenchmarks. This category is used for the latency sensitive work we care about, and setting this category disables open iterator tracking. **storage: use `(*testing.B).Loop` where relevant** Use the new (*testing.B).Loop helper where relevant to run b.N times, updating the timer to only measure the b.N iterations. **storage: use `(*testing.B).Context`** Use (*testing.B).Context instead of constructing a separate background context in the storage microbenchmarks. 159188: workload: remove FK dependency check in schemachanger drop column r=spilchen a=spilchen The schemachanger previously attempted to predict whether a DROP COLUMN operation would fail due to a foreign key (FK) dependency. This logic has proven to be unreliable and difficult to maintain correctly. Rather than investing more effort into fixing the latest edge cases, we’ve decided to remove the FK dependency detection logic altogether. This simplifies the codebase. Resolves: cockroachdb#159034 Release note: none Co-authored-by: Jackson Owens <jackson@cockroachlabs.com> Co-authored-by: Matt Spilchen <matt.spilchen@cockroachlabs.com>

This test is flaky and superfluous as our mixed version roachtests already test backup with offline nodes. Fixes: cockroachdb#158654 Release note: None

- Add Java 11 setup (required for Railroad JAR) - Download and configure Railroad Diagram Generator JAR - Set COCKROACH_REQUIRE_RAILROAD environment variable - Add fallback build command with explicit JAR location This should enable HTML/SVG diagram generation on GitHub-hosted runners. Epic: None Release note: None

The unzip was conflicting with existing LICENSE file in the repo. Now extracting in a temporary directory to avoid conflicts. Epic: None Release note: None

Adding diagnostic output to understand why HTML files aren't being generated. Epic: None Release note: None

Testing the workflow with debug output to see why HTML files aren't generated. Epic: None Release note: None

The dev wrapper requires initialization which doesn't work well on GitHub-hosted runners. Using bazel directly for: - BNF generation - SVG diagram building - Validation tests This should fix the HTML generation issue. Epic: None Release note: None

- Fix bazel output path detection using find command - Add Railroad JAR setup to bazel output base - Update artifact copying logic with proper HTML directory detection - Should now correctly find and copy all 313 HTML files

github-actions · 2025-12-23T15:21:17Z

SQL Diagram Generation Report

✅ Validation Passed

✔️ No diagram changes detected

SKIP DOC Warnings

The following grammar rules are suppressed from documentation:

The following grammar rules are suppressed with SKIP DOC:
1977:| alter_virtual_cluster_stmt   /* SKIP DOC */
2570:    /* SKIP DOC */
2582:    /* SKIP DOC */
2707:    /* SKIP DOC */
2724:    /* SKIP DOC */
3035:    /* SKIP DOC */
3041:    /* SKIP DOC */
3093:    /* SKIP DOC */
3205:  SET CYCLE                        { /* SKIP DOC */
3591:    /* SKIP DOC */
3612:  INCLUDE_ALL_SECONDARY_TENANTS { /* SKIP DOC */ }
4197:  TENANT  { /* SKIP DOC */ }
4201:  TENANT_NAME { /* SKIP DOC */ }
4792:    /* SKIP DOC */
4935:  /* SKIP DOC */
4974:    /* SKIP DOC */
4981:    /* SKIP DOC */
4989:    /* SKIP DOC */
4999:    /* SKIP DOC */
5011:  TENANT { /* SKIP DOC */ }
6203:    /* SKIP DOC */
6241:    /* SKIP DOC */
6318:    /* SKIP DOC */
6441:    /* SKIP DOC */
6727:   /* SKIP DOC */
6736:    /* SKIP DOC */
7158:    /* SKIP DOC */
7169:    /* SKIP DOC */
7174:    /* SKIP DOC */
7179:    /* SKIP DOC */
7198:    /* SKIP DOC */
7203:    /* SKIP DOC */
7210:    /* SKIP DOC */
7215:    /* SKIP DOC */
7220:    /* SKIP DOC */
7225:    /* SKIP DOC */
7232:    /* SKIP DOC */
7239:    /* SKIP DOC */
7254:		/* SKIP DOC */
7264:    /* SKIP DOC */
7269:    /* SKIP DOC */
7276:    /* SKIP DOC */
7295:    /* SKIP DOC */
7328:    /* SKIP DOC */
7786:| set_exprs_internal   { /* SKIP DOC */ }
8091:    /* SKIP DOC */
8120:    /* SKIP DOC */
8221:    /* SKIP DOC */
8230:    /* SKIP DOC */
8239:    /* SKIP DOC */
8299:    /* SKIP DOC */
8306:    /* SKIP DOC */
8316:    /* SKIP DOC */
8321:    /* SKIP DOC */
8346:    /* SKIP DOC */
8352:    /* SKIP DOC */
8429:    /* SKIP DOC */
8437:    /* SKIP DOC */
8442:		/* SKIP DOC */
8451:    /* SKIP DOC */
8472:    /* SKIP DOC */
8477:    /* SKIP DOC */
8885:    /* SKIP DOC */
8890:    /* SKIP DOC */
8895:    /* SKIP DOC */
8900:    /* SKIP DOC */
8905:    /* SKIP DOC */
8936:| TRACING { /* SKIP DOC */ }
8939:    /* SKIP DOC */
8981:    /* SKIP DOC */
9002:    /* SKIP DOC */
9054:    /* SKIP DOC */
9060:    /* SKIP DOC */
9066:		/* SKIP DOC */
9072:		/* SKIP DOC */
9089:    /* SKIP DOC */
9094:    /* SKIP DOC */
9099:    /* SKIP DOC */
9177: /* SKIP DOC */
9239:    /* SKIP DOC */
9244:    /* SKIP DOC */
9743:    /* SKIP DOC */
9908:    /* SKIP DOC */
9916:    /* SKIP DOC */
9929:    /* SKIP DOC */
9939:   /* SKIP DOC */
9972:    /* SKIP DOC */
9977:    /* SKIP DOC */
9982:    /* SKIP DOC */
10022:    /* SKIP DOC */
10031:    /* SKIP DOC */
10040:    /* SKIP DOC */
10045:    /* SKIP DOC */
10050:    /* SKIP DOC */
10055:    /* SKIP DOC */
10060:    /* SKIP DOC */
10069:    /* SKIP DOC */
10079:    /* SKIP DOC */
10255:| for_with_lookahead_variants { /* SKIP DOC */ }
10262:| FOR_JOB { /* SKIP DOC */ }
10457:    /* SKIP DOC */
10466:    /* SKIP DOC */
10775:    /* SKIP DOC */
10784:    /* SKIP DOC */
11093:    /* SKIP DOC */
11109:    /* SKIP DOC */
11199:| WITH DATA    { /* SKIP DOC */ /* This is the default */ }
11590:    /* SKIP DOC */
12097:| CYCLE                        { /* SKIP DOC */
12153:    /* SKIP DOC */
12234:    /* SKIP DOC */
12257:    /* SKIP DOC */
12535:    /* SKIP DOC */
12541:    /* SKIP DOC */
12546:    /* SKIP DOC */
12551:    /* SKIP DOC */
13575:| abort_stmt               /* SKIP DOC */
13905:    /* SKIP DOC */
13920:    /* SKIP DOC */
14066:    /* SKIP DOC */
14567:    /* SKIP DOC */
14990:    /* SKIP DOC */
14995:    /* SKIP DOC */
15000:    /* SKIP DOC */
15022:    /* SKIP DOC */
15027:    /* SKIP DOC */
15040:    /* SKIP DOC */
15045:    /* SKIP DOC */
15120:    /* SKIP DOC */
15206:    /* SKIP DOC */
15535:    /* SKIP DOC */
15607:    /* SKIP DOC */
15636:    /* SKIP DOC */

This comment was generated by the SQL Diagram CI workflow.

- Remove manual Railroad JAR download and setup - Let Bazel fetch the JAR automatically via http_archive in WORKSPACE - Add --verbose_failures to help debug any remaining issues - Should now properly generate HTML/SVG diagram files

github-actions · 2025-12-23T15:54:57Z

SQL Diagram Generation Report

✅ Validation Passed

✔️ No diagram changes detected

SKIP DOC Warnings

The following grammar rules are suppressed from documentation:

The following grammar rules are suppressed with SKIP DOC:
1977:| alter_virtual_cluster_stmt   /* SKIP DOC */
2570:    /* SKIP DOC */
2582:    /* SKIP DOC */
2707:    /* SKIP DOC */
2724:    /* SKIP DOC */
3035:    /* SKIP DOC */
3041:    /* SKIP DOC */
3093:    /* SKIP DOC */
3205:  SET CYCLE                        { /* SKIP DOC */
3591:    /* SKIP DOC */
3612:  INCLUDE_ALL_SECONDARY_TENANTS { /* SKIP DOC */ }
4197:  TENANT  { /* SKIP DOC */ }
4201:  TENANT_NAME { /* SKIP DOC */ }
4792:    /* SKIP DOC */
4935:  /* SKIP DOC */
4974:    /* SKIP DOC */
4981:    /* SKIP DOC */
4989:    /* SKIP DOC */
4999:    /* SKIP DOC */
5011:  TENANT { /* SKIP DOC */ }
6203:    /* SKIP DOC */
6241:    /* SKIP DOC */
6318:    /* SKIP DOC */
6441:    /* SKIP DOC */
6727:   /* SKIP DOC */
6736:    /* SKIP DOC */
7158:    /* SKIP DOC */
7169:    /* SKIP DOC */
7174:    /* SKIP DOC */
7179:    /* SKIP DOC */
7198:    /* SKIP DOC */
7203:    /* SKIP DOC */
7210:    /* SKIP DOC */
7215:    /* SKIP DOC */
7220:    /* SKIP DOC */
7225:    /* SKIP DOC */
7232:    /* SKIP DOC */
7239:    /* SKIP DOC */
7254:		/* SKIP DOC */
7264:    /* SKIP DOC */
7269:    /* SKIP DOC */
7276:    /* SKIP DOC */
7295:    /* SKIP DOC */
7328:    /* SKIP DOC */
7786:| set_exprs_internal   { /* SKIP DOC */ }
8091:    /* SKIP DOC */
8120:    /* SKIP DOC */
8221:    /* SKIP DOC */
8230:    /* SKIP DOC */
8239:    /* SKIP DOC */
8299:    /* SKIP DOC */
8306:    /* SKIP DOC */
8316:    /* SKIP DOC */
8321:    /* SKIP DOC */
8346:    /* SKIP DOC */
8352:    /* SKIP DOC */
8429:    /* SKIP DOC */
8437:    /* SKIP DOC */
8442:		/* SKIP DOC */
8451:    /* SKIP DOC */
8472:    /* SKIP DOC */
8477:    /* SKIP DOC */
8885:    /* SKIP DOC */
8890:    /* SKIP DOC */
8895:    /* SKIP DOC */
8900:    /* SKIP DOC */
8905:    /* SKIP DOC */
8936:| TRACING { /* SKIP DOC */ }
8939:    /* SKIP DOC */
8981:    /* SKIP DOC */
9002:    /* SKIP DOC */
9054:    /* SKIP DOC */
9060:    /* SKIP DOC */
9066:		/* SKIP DOC */
9072:		/* SKIP DOC */
9089:    /* SKIP DOC */
9094:    /* SKIP DOC */
9099:    /* SKIP DOC */
9177: /* SKIP DOC */
9239:    /* SKIP DOC */
9244:    /* SKIP DOC */
9743:    /* SKIP DOC */
9908:    /* SKIP DOC */
9916:    /* SKIP DOC */
9929:    /* SKIP DOC */
9939:   /* SKIP DOC */
9972:    /* SKIP DOC */
9977:    /* SKIP DOC */
9982:    /* SKIP DOC */
10022:    /* SKIP DOC */
10031:    /* SKIP DOC */
10040:    /* SKIP DOC */
10045:    /* SKIP DOC */
10050:    /* SKIP DOC */
10055:    /* SKIP DOC */
10060:    /* SKIP DOC */
10069:    /* SKIP DOC */
10079:    /* SKIP DOC */
10255:| for_with_lookahead_variants { /* SKIP DOC */ }
10262:| FOR_JOB { /* SKIP DOC */ }
10457:    /* SKIP DOC */
10466:    /* SKIP DOC */
10775:    /* SKIP DOC */
10784:    /* SKIP DOC */
11093:    /* SKIP DOC */
11109:    /* SKIP DOC */
11199:| WITH DATA    { /* SKIP DOC */ /* This is the default */ }
11590:    /* SKIP DOC */
12097:| CYCLE                        { /* SKIP DOC */
12153:    /* SKIP DOC */
12234:    /* SKIP DOC */
12257:    /* SKIP DOC */
12535:    /* SKIP DOC */
12541:    /* SKIP DOC */
12546:    /* SKIP DOC */
12551:    /* SKIP DOC */
13575:| abort_stmt               /* SKIP DOC */
13905:    /* SKIP DOC */
13920:    /* SKIP DOC */
14066:    /* SKIP DOC */
14567:    /* SKIP DOC */
14990:    /* SKIP DOC */
14995:    /* SKIP DOC */
15000:    /* SKIP DOC */
15022:    /* SKIP DOC */
15027:    /* SKIP DOC */
15040:    /* SKIP DOC */
15045:    /* SKIP DOC */
15120:    /* SKIP DOC */
15206:    /* SKIP DOC */
15535:    /* SKIP DOC */
15607:    /* SKIP DOC */
15636:    /* SKIP DOC */

This comment was generated by the SQL Diagram CI workflow.

- Pass JAVA_HOME, PATH, and COCKROACH_REQUIRE_RAILROAD to bazel via --action_env - Add debug output to verify Java setup - This fixes the 'Unable to locate a Java Runtime' error in docgen - Ensures Railroad JAR can be executed to generate HTML diagrams

github-actions · 2025-12-23T17:25:01Z

SQL Diagram Generation Report

✔️ No diagram changes detected

This comment was generated by the SQL Diagram CI workflow.

- Build docgen with bazel but run it directly outside sandbox - Fetch Railroad JAR from bazel's external directory - Add timeout to prevent hanging - Generate HTML files to artifacts/svg_output directory - This avoids the sandbox environment issues with Java runtime

github-actions · 2025-12-23T17:45:16Z

SQL Diagram Generation Report

✅ Validation Passed

✔️ No diagram changes detected

SKIP DOC Warnings

The following grammar rules are suppressed from documentation:

The following grammar rules are suppressed with SKIP DOC:
1977:| alter_virtual_cluster_stmt   /* SKIP DOC */
2570:    /* SKIP DOC */
2582:    /* SKIP DOC */
2707:    /* SKIP DOC */
2724:    /* SKIP DOC */
3035:    /* SKIP DOC */
3041:    /* SKIP DOC */
3093:    /* SKIP DOC */
3205:  SET CYCLE                        { /* SKIP DOC */
3591:    /* SKIP DOC */
3612:  INCLUDE_ALL_SECONDARY_TENANTS { /* SKIP DOC */ }
4197:  TENANT  { /* SKIP DOC */ }
4201:  TENANT_NAME { /* SKIP DOC */ }
4792:    /* SKIP DOC */
4935:  /* SKIP DOC */
4974:    /* SKIP DOC */
4981:    /* SKIP DOC */
4989:    /* SKIP DOC */
4999:    /* SKIP DOC */
5011:  TENANT { /* SKIP DOC */ }
6203:    /* SKIP DOC */
6241:    /* SKIP DOC */
6318:    /* SKIP DOC */
6441:    /* SKIP DOC */
6727:   /* SKIP DOC */
6736:    /* SKIP DOC */
7158:    /* SKIP DOC */
7169:    /* SKIP DOC */
7174:    /* SKIP DOC */
7179:    /* SKIP DOC */
7198:    /* SKIP DOC */
7203:    /* SKIP DOC */
7210:    /* SKIP DOC */
7215:    /* SKIP DOC */
7220:    /* SKIP DOC */
7225:    /* SKIP DOC */
7232:    /* SKIP DOC */
7239:    /* SKIP DOC */
7254:		/* SKIP DOC */
7264:    /* SKIP DOC */
7269:    /* SKIP DOC */
7276:    /* SKIP DOC */
7295:    /* SKIP DOC */
7328:    /* SKIP DOC */
7786:| set_exprs_internal   { /* SKIP DOC */ }
8091:    /* SKIP DOC */
8120:    /* SKIP DOC */
8221:    /* SKIP DOC */
8230:    /* SKIP DOC */
8239:    /* SKIP DOC */
8299:    /* SKIP DOC */
8306:    /* SKIP DOC */
8316:    /* SKIP DOC */
8321:    /* SKIP DOC */
8346:    /* SKIP DOC */
8352:    /* SKIP DOC */
8429:    /* SKIP DOC */
8437:    /* SKIP DOC */
8442:		/* SKIP DOC */
8451:    /* SKIP DOC */
8472:    /* SKIP DOC */
8477:    /* SKIP DOC */
8885:    /* SKIP DOC */
8890:    /* SKIP DOC */
8895:    /* SKIP DOC */
8900:    /* SKIP DOC */
8905:    /* SKIP DOC */
8936:| TRACING { /* SKIP DOC */ }
8939:    /* SKIP DOC */
8981:    /* SKIP DOC */
9002:    /* SKIP DOC */
9054:    /* SKIP DOC */
9060:    /* SKIP DOC */
9066:		/* SKIP DOC */
9072:		/* SKIP DOC */
9089:    /* SKIP DOC */
9094:    /* SKIP DOC */
9099:    /* SKIP DOC */
9177: /* SKIP DOC */
9239:    /* SKIP DOC */
9244:    /* SKIP DOC */
9743:    /* SKIP DOC */
9908:    /* SKIP DOC */
9916:    /* SKIP DOC */
9929:    /* SKIP DOC */
9939:   /* SKIP DOC */
9972:    /* SKIP DOC */
9977:    /* SKIP DOC */
9982:    /* SKIP DOC */
10022:    /* SKIP DOC */
10031:    /* SKIP DOC */
10040:    /* SKIP DOC */
10045:    /* SKIP DOC */
10050:    /* SKIP DOC */
10055:    /* SKIP DOC */
10060:    /* SKIP DOC */
10069:    /* SKIP DOC */
10079:    /* SKIP DOC */
10255:| for_with_lookahead_variants { /* SKIP DOC */ }
10262:| FOR_JOB { /* SKIP DOC */ }
10457:    /* SKIP DOC */
10466:    /* SKIP DOC */
10775:    /* SKIP DOC */
10784:    /* SKIP DOC */
11093:    /* SKIP DOC */
11109:    /* SKIP DOC */
11199:| WITH DATA    { /* SKIP DOC */ /* This is the default */ }
11590:    /* SKIP DOC */
12097:| CYCLE                        { /* SKIP DOC */
12153:    /* SKIP DOC */
12234:    /* SKIP DOC */
12257:    /* SKIP DOC */
12535:    /* SKIP DOC */
12541:    /* SKIP DOC */
12546:    /* SKIP DOC */
12551:    /* SKIP DOC */
13575:| abort_stmt               /* SKIP DOC */
13905:    /* SKIP DOC */
13920:    /* SKIP DOC */
14066:    /* SKIP DOC */
14567:    /* SKIP DOC */
14990:    /* SKIP DOC */
14995:    /* SKIP DOC */
15000:    /* SKIP DOC */
15022:    /* SKIP DOC */
15027:    /* SKIP DOC */
15040:    /* SKIP DOC */
15045:    /* SKIP DOC */
15120:    /* SKIP DOC */
15206:    /* SKIP DOC */
15535:    /* SKIP DOC */
15607:    /* SKIP DOC */
15636:    /* SKIP DOC */

This comment was generated by the SQL Diagram CI workflow.

- Remove partition_by and var_set_list from inline parameters - Add alter_index_cmds to unlink list - This simplifies the ALTER INDEX diagram visualization Epic: None Release note: None

github-actions · 2025-12-24T12:11:30Z

SQL Diagram Generation Report

✅ Validation Passed

✔️ No diagram changes detected

SKIP DOC Warnings

The following grammar rules are suppressed from documentation:

The following grammar rules are suppressed with SKIP DOC:
1977:| alter_virtual_cluster_stmt   /* SKIP DOC */
2570:    /* SKIP DOC */
2582:    /* SKIP DOC */
2707:    /* SKIP DOC */
2724:    /* SKIP DOC */
3035:    /* SKIP DOC */
3041:    /* SKIP DOC */
3093:    /* SKIP DOC */
3205:  SET CYCLE                        { /* SKIP DOC */
3591:    /* SKIP DOC */
3612:  INCLUDE_ALL_SECONDARY_TENANTS { /* SKIP DOC */ }
4197:  TENANT  { /* SKIP DOC */ }
4201:  TENANT_NAME { /* SKIP DOC */ }
4792:    /* SKIP DOC */
4935:  /* SKIP DOC */
4974:    /* SKIP DOC */
4981:    /* SKIP DOC */
4989:    /* SKIP DOC */
4999:    /* SKIP DOC */
5011:  TENANT { /* SKIP DOC */ }
6203:    /* SKIP DOC */
6241:    /* SKIP DOC */
6318:    /* SKIP DOC */
6441:    /* SKIP DOC */
6727:   /* SKIP DOC */
6736:    /* SKIP DOC */
7158:    /* SKIP DOC */
7169:    /* SKIP DOC */
7174:    /* SKIP DOC */
7179:    /* SKIP DOC */
7198:    /* SKIP DOC */
7203:    /* SKIP DOC */
7210:    /* SKIP DOC */
7215:    /* SKIP DOC */
7220:    /* SKIP DOC */
7225:    /* SKIP DOC */
7232:    /* SKIP DOC */
7239:    /* SKIP DOC */
7254:		/* SKIP DOC */
7264:    /* SKIP DOC */
7269:    /* SKIP DOC */
7276:    /* SKIP DOC */
7295:    /* SKIP DOC */
7328:    /* SKIP DOC */
7786:| set_exprs_internal   { /* SKIP DOC */ }
8091:    /* SKIP DOC */
8120:    /* SKIP DOC */
8221:    /* SKIP DOC */
8230:    /* SKIP DOC */
8239:    /* SKIP DOC */
8299:    /* SKIP DOC */
8306:    /* SKIP DOC */
8316:    /* SKIP DOC */
8321:    /* SKIP DOC */
8346:    /* SKIP DOC */
8352:    /* SKIP DOC */
8429:    /* SKIP DOC */
8437:    /* SKIP DOC */
8442:		/* SKIP DOC */
8451:    /* SKIP DOC */
8472:    /* SKIP DOC */
8477:    /* SKIP DOC */
8885:    /* SKIP DOC */
8890:    /* SKIP DOC */
8895:    /* SKIP DOC */
8900:    /* SKIP DOC */
8905:    /* SKIP DOC */
8936:| TRACING { /* SKIP DOC */ }
8939:    /* SKIP DOC */
8981:    /* SKIP DOC */
9002:    /* SKIP DOC */
9054:    /* SKIP DOC */
9060:    /* SKIP DOC */
9066:		/* SKIP DOC */
9072:		/* SKIP DOC */
9089:    /* SKIP DOC */
9094:    /* SKIP DOC */
9099:    /* SKIP DOC */
9177: /* SKIP DOC */
9239:    /* SKIP DOC */
9244:    /* SKIP DOC */
9743:    /* SKIP DOC */
9908:    /* SKIP DOC */
9916:    /* SKIP DOC */
9929:    /* SKIP DOC */
9939:   /* SKIP DOC */
9972:    /* SKIP DOC */
9977:    /* SKIP DOC */
9982:    /* SKIP DOC */
10022:    /* SKIP DOC */
10031:    /* SKIP DOC */
10040:    /* SKIP DOC */
10045:    /* SKIP DOC */
10050:    /* SKIP DOC */
10055:    /* SKIP DOC */
10060:    /* SKIP DOC */
10069:    /* SKIP DOC */
10079:    /* SKIP DOC */
10255:| for_with_lookahead_variants { /* SKIP DOC */ }
10262:| FOR_JOB { /* SKIP DOC */ }
10457:    /* SKIP DOC */
10466:    /* SKIP DOC */
10775:    /* SKIP DOC */
10784:    /* SKIP DOC */
11093:    /* SKIP DOC */
11109:    /* SKIP DOC */
11199:| WITH DATA    { /* SKIP DOC */ /* This is the default */ }
11590:    /* SKIP DOC */
12097:| CYCLE                        { /* SKIP DOC */
12153:    /* SKIP DOC */
12234:    /* SKIP DOC */
12257:    /* SKIP DOC */
12535:    /* SKIP DOC */
12541:    /* SKIP DOC */
12546:    /* SKIP DOC */
12551:    /* SKIP DOC */
13575:| abort_stmt               /* SKIP DOC */
13905:    /* SKIP DOC */
13920:    /* SKIP DOC */
14066:    /* SKIP DOC */
14567:    /* SKIP DOC */
14990:    /* SKIP DOC */
14995:    /* SKIP DOC */
15000:    /* SKIP DOC */
15022:    /* SKIP DOC */
15027:    /* SKIP DOC */
15040:    /* SKIP DOC */
15045:    /* SKIP DOC */
15120:    /* SKIP DOC */
15206:    /* SKIP DOC */
15535:    /* SKIP DOC */
15607:    /* SKIP DOC */
15636:    /* SKIP DOC */

This comment was generated by the SQL Diagram CI workflow.

Adding more inline parameters to restore_options spec to create actual diagram output changes that should trigger PR creation to generated-diagrams repository

Removed several inline elements and simplified replace/unlink maps to create actual diagram output changes that will trigger PR creation to generated-diagrams repository Changes: - Removed inline: alter_unsplit_stmt, alter_zone_table_stmt, alter_table_locality_stmt, set_zone_config, var_set_list - Simplified replace map to only map relation_expr to table_name - Reduced unlink list to only table_name

github-actions · 2025-12-24T12:28:33Z

SQL Diagram Generation Report

✔️ No diagram changes detected

This comment was generated by the SQL Diagram CI workflow.

…nges The previous change detection using 'git diff HEAD' was broken because it compared against our own repository's HEAD, not the generated-diagrams repository. This meant changes were never detected. Now we always proceed to the sync job and let the create-pull-request action handle the actual diff detection - it won't create a PR if there are no changes.

github-actions · 2025-12-24T12:42:39Z

SQL Diagram Generation Report

✔️ No diagram changes detected

This comment was generated by the SQL Diagram CI workflow.

github-actions · 2025-12-24T13:00:28Z

SQL Diagram Generation Report

✅ Validation Passed

🔄 Diagram changes detected
A PR will be automatically opened in generated-diagrams to sync these changes.

Changed Diagrams

pending

SKIP DOC Warnings

The following grammar rules are suppressed from documentation:

The following grammar rules are suppressed with SKIP DOC:
1977:| alter_virtual_cluster_stmt   /* SKIP DOC */
2570:    /* SKIP DOC */
2582:    /* SKIP DOC */
2707:    /* SKIP DOC */
2724:    /* SKIP DOC */
3035:    /* SKIP DOC */
3041:    /* SKIP DOC */
3093:    /* SKIP DOC */
3205:  SET CYCLE                        { /* SKIP DOC */
3591:    /* SKIP DOC */
3612:  INCLUDE_ALL_SECONDARY_TENANTS { /* SKIP DOC */ }
4197:  TENANT  { /* SKIP DOC */ }
4201:  TENANT_NAME { /* SKIP DOC */ }
4792:    /* SKIP DOC */
4935:  /* SKIP DOC */
4974:    /* SKIP DOC */
4981:    /* SKIP DOC */
4989:    /* SKIP DOC */
4999:    /* SKIP DOC */
5011:  TENANT { /* SKIP DOC */ }
6203:    /* SKIP DOC */
6241:    /* SKIP DOC */
6318:    /* SKIP DOC */
6441:    /* SKIP DOC */
6727:   /* SKIP DOC */
6736:    /* SKIP DOC */
7158:    /* SKIP DOC */
7169:    /* SKIP DOC */
7174:    /* SKIP DOC */
7179:    /* SKIP DOC */
7198:    /* SKIP DOC */
7203:    /* SKIP DOC */
7210:    /* SKIP DOC */
7215:    /* SKIP DOC */
7220:    /* SKIP DOC */
7225:    /* SKIP DOC */
7232:    /* SKIP DOC */
7239:    /* SKIP DOC */
7254:		/* SKIP DOC */
7264:    /* SKIP DOC */
7269:    /* SKIP DOC */
7276:    /* SKIP DOC */
7295:    /* SKIP DOC */
7328:    /* SKIP DOC */
7786:| set_exprs_internal   { /* SKIP DOC */ }
8091:    /* SKIP DOC */
8120:    /* SKIP DOC */
8221:    /* SKIP DOC */
8230:    /* SKIP DOC */
8239:    /* SKIP DOC */
8299:    /* SKIP DOC */
8306:    /* SKIP DOC */
8316:    /* SKIP DOC */
8321:    /* SKIP DOC */
8346:    /* SKIP DOC */
8352:    /* SKIP DOC */
8429:    /* SKIP DOC */
8437:    /* SKIP DOC */
8442:		/* SKIP DOC */
8451:    /* SKIP DOC */
8472:    /* SKIP DOC */
8477:    /* SKIP DOC */
8885:    /* SKIP DOC */
8890:    /* SKIP DOC */
8895:    /* SKIP DOC */
8900:    /* SKIP DOC */
8905:    /* SKIP DOC */
8936:| TRACING { /* SKIP DOC */ }
8939:    /* SKIP DOC */
8981:    /* SKIP DOC */
9002:    /* SKIP DOC */
9054:    /* SKIP DOC */
9060:    /* SKIP DOC */
9066:		/* SKIP DOC */
9072:		/* SKIP DOC */
9089:    /* SKIP DOC */
9094:    /* SKIP DOC */
9099:    /* SKIP DOC */
9177: /* SKIP DOC */
9239:    /* SKIP DOC */
9244:    /* SKIP DOC */
9743:    /* SKIP DOC */
9908:    /* SKIP DOC */
9916:    /* SKIP DOC */
9929:    /* SKIP DOC */
9939:   /* SKIP DOC */
9972:    /* SKIP DOC */
9977:    /* SKIP DOC */
9982:    /* SKIP DOC */
10022:    /* SKIP DOC */
10031:    /* SKIP DOC */
10040:    /* SKIP DOC */
10045:    /* SKIP DOC */
10050:    /* SKIP DOC */
10055:    /* SKIP DOC */
10060:    /* SKIP DOC */
10069:    /* SKIP DOC */
10079:    /* SKIP DOC */
10255:| for_with_lookahead_variants { /* SKIP DOC */ }
10262:| FOR_JOB { /* SKIP DOC */ }
10457:    /* SKIP DOC */
10466:    /* SKIP DOC */
10775:    /* SKIP DOC */
10784:    /* SKIP DOC */
11093:    /* SKIP DOC */
11109:    /* SKIP DOC */
11199:| WITH DATA    { /* SKIP DOC */ /* This is the default */ }
11590:    /* SKIP DOC */
12097:| CYCLE                        { /* SKIP DOC */
12153:    /* SKIP DOC */
12234:    /* SKIP DOC */
12257:    /* SKIP DOC */
12535:    /* SKIP DOC */
12541:    /* SKIP DOC */
12546:    /* SKIP DOC */
12551:    /* SKIP DOC */
13575:| abort_stmt               /* SKIP DOC */
13905:    /* SKIP DOC */
13920:    /* SKIP DOC */
14066:    /* SKIP DOC */
14567:    /* SKIP DOC */
14990:    /* SKIP DOC */
14995:    /* SKIP DOC */
15000:    /* SKIP DOC */
15022:    /* SKIP DOC */
15027:    /* SKIP DOC */
15040:    /* SKIP DOC */
15045:    /* SKIP DOC */
15120:    /* SKIP DOC */
15206:    /* SKIP DOC */
15535:    /* SKIP DOC */
15607:    /* SKIP DOC */
15636:    /* SKIP DOC */

This comment was generated by the SQL Diagram CI workflow.

github-actions · 2025-12-24T13:37:33Z

SQL Diagram Generation Report

✅ Validation Passed

🔄 Diagram changes detected
A PR will be automatically opened in generated-diagrams to sync these changes.

Changed Diagrams

pending

SKIP DOC Warnings

The following grammar rules are suppressed from documentation:

The following grammar rules are suppressed with SKIP DOC:
1977:| alter_virtual_cluster_stmt   /* SKIP DOC */
2570:    /* SKIP DOC */
2582:    /* SKIP DOC */
2707:    /* SKIP DOC */
2724:    /* SKIP DOC */
3035:    /* SKIP DOC */
3041:    /* SKIP DOC */
3093:    /* SKIP DOC */
3205:  SET CYCLE                        { /* SKIP DOC */
3591:    /* SKIP DOC */
3612:  INCLUDE_ALL_SECONDARY_TENANTS { /* SKIP DOC */ }
4197:  TENANT  { /* SKIP DOC */ }
4201:  TENANT_NAME { /* SKIP DOC */ }
4792:    /* SKIP DOC */
4935:  /* SKIP DOC */
4974:    /* SKIP DOC */
4981:    /* SKIP DOC */
4989:    /* SKIP DOC */
4999:    /* SKIP DOC */
5011:  TENANT { /* SKIP DOC */ }
6203:    /* SKIP DOC */
6241:    /* SKIP DOC */
6318:    /* SKIP DOC */
6441:    /* SKIP DOC */
6727:   /* SKIP DOC */
6736:    /* SKIP DOC */
7158:    /* SKIP DOC */
7169:    /* SKIP DOC */
7174:    /* SKIP DOC */
7179:    /* SKIP DOC */
7198:    /* SKIP DOC */
7203:    /* SKIP DOC */
7210:    /* SKIP DOC */
7215:    /* SKIP DOC */
7220:    /* SKIP DOC */
7225:    /* SKIP DOC */
7232:    /* SKIP DOC */
7239:    /* SKIP DOC */
7254:		/* SKIP DOC */
7264:    /* SKIP DOC */
7269:    /* SKIP DOC */
7276:    /* SKIP DOC */
7295:    /* SKIP DOC */
7328:    /* SKIP DOC */
7786:| set_exprs_internal   { /* SKIP DOC */ }
8091:    /* SKIP DOC */
8120:    /* SKIP DOC */
8221:    /* SKIP DOC */
8230:    /* SKIP DOC */
8239:    /* SKIP DOC */
8299:    /* SKIP DOC */
8306:    /* SKIP DOC */
8316:    /* SKIP DOC */
8321:    /* SKIP DOC */
8346:    /* SKIP DOC */
8352:    /* SKIP DOC */
8429:    /* SKIP DOC */
8437:    /* SKIP DOC */
8442:		/* SKIP DOC */
8451:    /* SKIP DOC */
8472:    /* SKIP DOC */
8477:    /* SKIP DOC */
8885:    /* SKIP DOC */
8890:    /* SKIP DOC */
8895:    /* SKIP DOC */
8900:    /* SKIP DOC */
8905:    /* SKIP DOC */
8936:| TRACING { /* SKIP DOC */ }
8939:    /* SKIP DOC */
8981:    /* SKIP DOC */
9002:    /* SKIP DOC */
9054:    /* SKIP DOC */
9060:    /* SKIP DOC */
9066:		/* SKIP DOC */
9072:		/* SKIP DOC */
9089:    /* SKIP DOC */
9094:    /* SKIP DOC */
9099:    /* SKIP DOC */
9177: /* SKIP DOC */
9239:    /* SKIP DOC */
9244:    /* SKIP DOC */
9743:    /* SKIP DOC */
9908:    /* SKIP DOC */
9916:    /* SKIP DOC */
9929:    /* SKIP DOC */
9939:   /* SKIP DOC */
9972:    /* SKIP DOC */
9977:    /* SKIP DOC */
9982:    /* SKIP DOC */
10022:    /* SKIP DOC */
10031:    /* SKIP DOC */
10040:    /* SKIP DOC */
10045:    /* SKIP DOC */
10050:    /* SKIP DOC */
10055:    /* SKIP DOC */
10060:    /* SKIP DOC */
10069:    /* SKIP DOC */
10079:    /* SKIP DOC */
10255:| for_with_lookahead_variants { /* SKIP DOC */ }
10262:| FOR_JOB { /* SKIP DOC */ }
10457:    /* SKIP DOC */
10466:    /* SKIP DOC */
10775:    /* SKIP DOC */
10784:    /* SKIP DOC */
11093:    /* SKIP DOC */
11109:    /* SKIP DOC */
11199:| WITH DATA    { /* SKIP DOC */ /* This is the default */ }
11590:    /* SKIP DOC */
12097:| CYCLE                        { /* SKIP DOC */
12153:    /* SKIP DOC */
12234:    /* SKIP DOC */
12257:    /* SKIP DOC */
12535:    /* SKIP DOC */
12541:    /* SKIP DOC */
12546:    /* SKIP DOC */
12551:    /* SKIP DOC */
13575:| abort_stmt               /* SKIP DOC */
13905:    /* SKIP DOC */
13920:    /* SKIP DOC */
14066:    /* SKIP DOC */
14567:    /* SKIP DOC */
14990:    /* SKIP DOC */
14995:    /* SKIP DOC */
15000:    /* SKIP DOC */
15022:    /* SKIP DOC */
15027:    /* SKIP DOC */
15040:    /* SKIP DOC */
15045:    /* SKIP DOC */
15120:    /* SKIP DOC */
15206:    /* SKIP DOC */
15535:    /* SKIP DOC */
15607:    /* SKIP DOC */
15636:    /* SKIP DOC */

This comment was generated by the SQL Diagram CI workflow.

The generated-diagrams repository doesn't have our feature branch, so we must always use 'master' as the target branch when checking out and creating PRs to that repository.

github-actions · 2025-12-24T14:01:41Z

SQL Diagram Generation Report

✅ Validation Passed

🔄 Diagram changes detected
A PR has been opened to sync these changes: cockroachdb/generated-diagrams#19

Changed Diagrams

pending

SKIP DOC Warnings

The following grammar rules are suppressed from documentation:

The following grammar rules are suppressed with SKIP DOC:
1977:| alter_virtual_cluster_stmt   /* SKIP DOC */
2570:    /* SKIP DOC */
2582:    /* SKIP DOC */
2707:    /* SKIP DOC */
2724:    /* SKIP DOC */
3035:    /* SKIP DOC */
3041:    /* SKIP DOC */
3093:    /* SKIP DOC */
3205:  SET CYCLE                        { /* SKIP DOC */
3591:    /* SKIP DOC */
3612:  INCLUDE_ALL_SECONDARY_TENANTS { /* SKIP DOC */ }
4197:  TENANT  { /* SKIP DOC */ }
4201:  TENANT_NAME { /* SKIP DOC */ }
4792:    /* SKIP DOC */
4935:  /* SKIP DOC */
4974:    /* SKIP DOC */
4981:    /* SKIP DOC */
4989:    /* SKIP DOC */
4999:    /* SKIP DOC */
5011:  TENANT { /* SKIP DOC */ }
6203:    /* SKIP DOC */
6241:    /* SKIP DOC */
6318:    /* SKIP DOC */
6441:    /* SKIP DOC */
6727:   /* SKIP DOC */
6736:    /* SKIP DOC */
7158:    /* SKIP DOC */
7169:    /* SKIP DOC */
7174:    /* SKIP DOC */
7179:    /* SKIP DOC */
7198:    /* SKIP DOC */
7203:    /* SKIP DOC */
7210:    /* SKIP DOC */
7215:    /* SKIP DOC */
7220:    /* SKIP DOC */
7225:    /* SKIP DOC */
7232:    /* SKIP DOC */
7239:    /* SKIP DOC */
7254:		/* SKIP DOC */
7264:    /* SKIP DOC */
7269:    /* SKIP DOC */
7276:    /* SKIP DOC */
7295:    /* SKIP DOC */
7328:    /* SKIP DOC */
7786:| set_exprs_internal   { /* SKIP DOC */ }
8091:    /* SKIP DOC */
8120:    /* SKIP DOC */
8221:    /* SKIP DOC */
8230:    /* SKIP DOC */
8239:    /* SKIP DOC */
8299:    /* SKIP DOC */
8306:    /* SKIP DOC */
8316:    /* SKIP DOC */
8321:    /* SKIP DOC */
8346:    /* SKIP DOC */
8352:    /* SKIP DOC */
8429:    /* SKIP DOC */
8437:    /* SKIP DOC */
8442:		/* SKIP DOC */
8451:    /* SKIP DOC */
8472:    /* SKIP DOC */
8477:    /* SKIP DOC */
8885:    /* SKIP DOC */
8890:    /* SKIP DOC */
8895:    /* SKIP DOC */
8900:    /* SKIP DOC */
8905:    /* SKIP DOC */
8936:| TRACING { /* SKIP DOC */ }
8939:    /* SKIP DOC */
8981:    /* SKIP DOC */
9002:    /* SKIP DOC */
9054:    /* SKIP DOC */
9060:    /* SKIP DOC */
9066:		/* SKIP DOC */
9072:		/* SKIP DOC */
9089:    /* SKIP DOC */
9094:    /* SKIP DOC */
9099:    /* SKIP DOC */
9177: /* SKIP DOC */
9239:    /* SKIP DOC */
9244:    /* SKIP DOC */
9743:    /* SKIP DOC */
9908:    /* SKIP DOC */
9916:    /* SKIP DOC */
9929:    /* SKIP DOC */
9939:   /* SKIP DOC */
9972:    /* SKIP DOC */
9977:    /* SKIP DOC */
9982:    /* SKIP DOC */
10022:    /* SKIP DOC */
10031:    /* SKIP DOC */
10040:    /* SKIP DOC */
10045:    /* SKIP DOC */
10050:    /* SKIP DOC */
10055:    /* SKIP DOC */
10060:    /* SKIP DOC */
10069:    /* SKIP DOC */
10079:    /* SKIP DOC */
10255:| for_with_lookahead_variants { /* SKIP DOC */ }
10262:| FOR_JOB { /* SKIP DOC */ }
10457:    /* SKIP DOC */
10466:    /* SKIP DOC */
10775:    /* SKIP DOC */
10784:    /* SKIP DOC */
11093:    /* SKIP DOC */
11109:    /* SKIP DOC */
11199:| WITH DATA    { /* SKIP DOC */ /* This is the default */ }
11590:    /* SKIP DOC */
12097:| CYCLE                        { /* SKIP DOC */
12153:    /* SKIP DOC */
12234:    /* SKIP DOC */
12257:    /* SKIP DOC */
12535:    /* SKIP DOC */
12541:    /* SKIP DOC */
12546:    /* SKIP DOC */
12551:    /* SKIP DOC */
13575:| abort_stmt               /* SKIP DOC */
13905:    /* SKIP DOC */
13920:    /* SKIP DOC */
14066:    /* SKIP DOC */
14567:    /* SKIP DOC */
14990:    /* SKIP DOC */
14995:    /* SKIP DOC */
15000:    /* SKIP DOC */
15022:    /* SKIP DOC */
15027:    /* SKIP DOC */
15040:    /* SKIP DOC */
15045:    /* SKIP DOC */
15120:    /* SKIP DOC */
15206:    /* SKIP DOC */
15535:    /* SKIP DOC */
15607:    /* SKIP DOC */
15636:    /* SKIP DOC */

This comment was generated by the SQL Diagram CI workflow.

The manifest.json file is not needed for the diagram generation pipeline. Removing it simplifies the artifacts and PR content.

Prevent accidentally committing downloaded diagram artifacts

github-actions · 2025-12-24T15:14:23Z

SQL Diagram Generation Report

✅ Validation Passed

🔄 Diagram changes detected
A PR has been opened to sync these changes: cockroachdb/generated-diagrams#20

Changed Diagrams

pending

SKIP DOC Warnings

The following grammar rules are suppressed from documentation:

The following grammar rules are suppressed with SKIP DOC:
1977:| alter_virtual_cluster_stmt   /* SKIP DOC */
2570:    /* SKIP DOC */
2582:    /* SKIP DOC */
2707:    /* SKIP DOC */
2724:    /* SKIP DOC */
3035:    /* SKIP DOC */
3041:    /* SKIP DOC */
3093:    /* SKIP DOC */
3205:  SET CYCLE                        { /* SKIP DOC */
3591:    /* SKIP DOC */
3612:  INCLUDE_ALL_SECONDARY_TENANTS { /* SKIP DOC */ }
4197:  TENANT  { /* SKIP DOC */ }
4201:  TENANT_NAME { /* SKIP DOC */ }
4792:    /* SKIP DOC */
4935:  /* SKIP DOC */
4974:    /* SKIP DOC */
4981:    /* SKIP DOC */
4989:    /* SKIP DOC */
4999:    /* SKIP DOC */
5011:  TENANT { /* SKIP DOC */ }
6203:    /* SKIP DOC */
6241:    /* SKIP DOC */
6318:    /* SKIP DOC */
6441:    /* SKIP DOC */
6727:   /* SKIP DOC */
6736:    /* SKIP DOC */
7158:    /* SKIP DOC */
7169:    /* SKIP DOC */
7174:    /* SKIP DOC */
7179:    /* SKIP DOC */
7198:    /* SKIP DOC */
7203:    /* SKIP DOC */
7210:    /* SKIP DOC */
7215:    /* SKIP DOC */
7220:    /* SKIP DOC */
7225:    /* SKIP DOC */
7232:    /* SKIP DOC */
7239:    /* SKIP DOC */
7254:		/* SKIP DOC */
7264:    /* SKIP DOC */
7269:    /* SKIP DOC */
7276:    /* SKIP DOC */
7295:    /* SKIP DOC */
7328:    /* SKIP DOC */
7786:| set_exprs_internal   { /* SKIP DOC */ }
8091:    /* SKIP DOC */
8120:    /* SKIP DOC */
8221:    /* SKIP DOC */
8230:    /* SKIP DOC */
8239:    /* SKIP DOC */
8299:    /* SKIP DOC */
8306:    /* SKIP DOC */
8316:    /* SKIP DOC */
8321:    /* SKIP DOC */
8346:    /* SKIP DOC */
8352:    /* SKIP DOC */
8429:    /* SKIP DOC */
8437:    /* SKIP DOC */
8442:		/* SKIP DOC */
8451:    /* SKIP DOC */
8472:    /* SKIP DOC */
8477:    /* SKIP DOC */
8885:    /* SKIP DOC */
8890:    /* SKIP DOC */
8895:    /* SKIP DOC */
8900:    /* SKIP DOC */
8905:    /* SKIP DOC */
8936:| TRACING { /* SKIP DOC */ }
8939:    /* SKIP DOC */
8981:    /* SKIP DOC */
9002:    /* SKIP DOC */
9054:    /* SKIP DOC */
9060:    /* SKIP DOC */
9066:		/* SKIP DOC */
9072:		/* SKIP DOC */
9089:    /* SKIP DOC */
9094:    /* SKIP DOC */
9099:    /* SKIP DOC */
9177: /* SKIP DOC */
9239:    /* SKIP DOC */
9244:    /* SKIP DOC */
9743:    /* SKIP DOC */
9908:    /* SKIP DOC */
9916:    /* SKIP DOC */
9929:    /* SKIP DOC */
9939:   /* SKIP DOC */
9972:    /* SKIP DOC */
9977:    /* SKIP DOC */
9982:    /* SKIP DOC */
10022:    /* SKIP DOC */
10031:    /* SKIP DOC */
10040:    /* SKIP DOC */
10045:    /* SKIP DOC */
10050:    /* SKIP DOC */
10055:    /* SKIP DOC */
10060:    /* SKIP DOC */
10069:    /* SKIP DOC */
10079:    /* SKIP DOC */
10255:| for_with_lookahead_variants { /* SKIP DOC */ }
10262:| FOR_JOB { /* SKIP DOC */ }
10457:    /* SKIP DOC */
10466:    /* SKIP DOC */
10775:    /* SKIP DOC */
10784:    /* SKIP DOC */
11093:    /* SKIP DOC */
11109:    /* SKIP DOC */
11199:| WITH DATA    { /* SKIP DOC */ /* This is the default */ }
11590:    /* SKIP DOC */
12097:| CYCLE                        { /* SKIP DOC */
12153:    /* SKIP DOC */
12234:    /* SKIP DOC */
12257:    /* SKIP DOC */
12535:    /* SKIP DOC */
12541:    /* SKIP DOC */
12546:    /* SKIP DOC */
12551:    /* SKIP DOC */
13575:| abort_stmt               /* SKIP DOC */
13905:    /* SKIP DOC */
13920:    /* SKIP DOC */
14066:    /* SKIP DOC */
14567:    /* SKIP DOC */
14990:    /* SKIP DOC */
14995:    /* SKIP DOC */
15000:    /* SKIP DOC */
15022:    /* SKIP DOC */
15027:    /* SKIP DOC */
15040:    /* SKIP DOC */
15045:    /* SKIP DOC */
15120:    /* SKIP DOC */
15206:    /* SKIP DOC */
15535:    /* SKIP DOC */
15607:    /* SKIP DOC */
15636:    /* SKIP DOC */

This comment was generated by the SQL Diagram CI workflow.

rafiss and others added 30 commits December 10, 2025 11:07

schemachanger: handle RESET storage param in declarative schema changer

f0c3852

This reuses the logic that was added to handle SET. The only difference is that RESET always drops the StorageParam element. Release note: None

build: no darwin-amd64 anymore

0da5287

Release note: none. Epic: none.

build: bump go fork SHA for runtime.Yield

378d575

Picks up cockroachdb/go#8 Release note: none. Epic: none.

Merge cockroachdb#159160

367d1b8

159160: intentresolver: skip TestIntentResolutionUnavailableRange under duress r=wenyihu6 a=arulajmani Closes cockroachdb#159050 Release note: None Co-authored-by: Arul Ajmani <arulajmani@gmail.com>

build: bump go gommit for debug=3 goroutine profiles

355d1a0

Release note: none. Epic: none.

Revert "kv: add TestDecommissionPreCheckRetryThrottledStores"

a01f02c

This reverts commit 0b2c0ce.

sql: ascii built-in should not error with an empty string

39dc95a

Fixes cockroachdb#159174 Release note (bug fix): The `ascii` built-in function now returns `0` when the input is the empty string instead of an error.

ui: bump cluster-ui version to 26.2.0-prerelease.0

3f81247

Epic: REL-3909 Resolves: CRDB-57502 Release note: None

roachtest: deflake npgsql

db4f97e

Recently we have been seeing the test "Wait_with_timeout" as flaky, so we will add it in the ignore list. Release note: None Fixes: cockroachdb#158495

storage: use fs.BatchEvalReadCategory in benchmarks

fcf9c63

Use the fs.BatchEvalReadCategory in microbenchmarks. This category is used for the latency sensitive work we care about, and setting this category disables open iterator tracking. Epic: none Release note: none

jobs: move JobSchedulerEnv helper function

7004788

Move this simple function to avoid a dependency cycle in an upcoming commit. Release note: None

storage: use (*testing.B).Loop where relevant

714a3b8

Use the new (*testing.B).Loop helper where relevant to run b.N times, updating the timer to only measure the b.N iterations. Epic: none Release note: none

storage: use (*testing.B).Context

c9dff0b

Use (*testing.B).Context instead of constructing a separate background context in the storage microbenchmarks. Epic: none Release note: none

sql: add query id to recorded statement stats in UDFs / SPs

a532703

Generates a query id for sub statements executed in UDFs and SPs. This is used by the insights system to provide execution specific insights. Epic: None Release note: None

backup: remove TestBackupSharedProcessTenantNodeDown

c538bad

This test is flaky and superfluous as our mixed version roachtests already test backup with offline nodes. Fixes: cockroachdb#158654 Release note: None

ebembi-crdb added 9 commits December 23, 2025 16:10

ci: fix Railroad JAR extraction in temp directory

de0fb5a

The unzip was conflicting with existing LICENSE file in the repo. Now extracting in a temporary directory to avoid conflicts. Epic: None Release note: None

ci: add debug output to SVG build step

74a6169

Adding diagnostic output to understand why HTML files aren't being generated. Epic: None Release note: None

Merge Railroad JAR fixes for GitHub-hosted runners

a6ce3c1

test: debug SVG generation - unlink string_or_placeholder

b31cbd2

Testing the workflow with debug output to see why HTML files aren't generated. Epic: None Release note: None

Merge bazel fixes for GitHub-hosted runners

5da652a

ci: fix HTML file detection and copying in workflow

c73ddf2

- Fix bazel output path detection using find command - Add Railroad JAR setup to bazel output base - Update artifact copying logic with proper HTML directory detection - Should now correctly find and copy all 313 HTML files

ci: add feature branch to workflow triggers

f8c2610

ci: fix Railroad JAR integration - let Bazel handle it

6c1de59

- Remove manual Railroad JAR download and setup - Let Bazel fetch the JAR automatically via http_archive in WORKSPACE - Add --verbose_failures to help debug any remaining issues - Should now properly generate HTML/SVG diagram files

docgen: update alter_index diagram specification

f20170f

- Remove partition_by and var_set_list from inline parameters - Add alter_index_cmds to unlink list - This simplifies the ALTER INDEX diagram visualization Epic: None Release note: None

ebembi-crdb added 2 commits December 24, 2025 17:50

docgen: modify restore_options diagram spec to trigger PR creation

8e92fe3

Adding more inline parameters to restore_options spec to create actual diagram output changes that should trigger PR creation to generated-diagrams repository

fix: use master branch for generated-diagrams repository

0ec26ff

The generated-diagrams repository doesn't have our feature branch, so we must always use 'master' as the target branch when checking out and creating PRs to that repository.

ebembi-crdb added 2 commits December 24, 2025 20:24

chore: remove manifest.json generation from workflow

ccabb83

The manifest.json file is not needed for the diagram generation pipeline. Removing it simplifies the artifacts and PR content.

chore: add sql-diagrams/ to .gitignore

4433dbc

Prevent accidentally committing downloaded diagram artifacts

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Test: Final SVG generation fix - end-to-end test #23

Test: Final SVG generation fix - end-to-end test #23

Uh oh!

ebembi-crdb commented Dec 23, 2025

Uh oh!

github-actions bot commented Dec 23, 2025

Uh oh!

github-actions bot commented Dec 23, 2025

Uh oh!

github-actions bot commented Dec 23, 2025

Uh oh!

github-actions bot commented Dec 23, 2025

Uh oh!

github-actions bot commented Dec 24, 2025

Uh oh!

github-actions bot commented Dec 24, 2025

Uh oh!

github-actions bot commented Dec 24, 2025

Uh oh!

github-actions bot commented Dec 24, 2025

Uh oh!

github-actions bot commented Dec 24, 2025

Uh oh!

github-actions bot commented Dec 24, 2025

Uh oh!

github-actions bot commented Dec 24, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Test: Final SVG generation fix - end-to-end test #23

Are you sure you want to change the base?

Test: Final SVG generation fix - end-to-end test #23

Uh oh!

Conversation

ebembi-crdb commented Dec 23, 2025

Summary

Changes

Expected Results

Testing

Uh oh!

github-actions bot commented Dec 23, 2025

SQL Diagram Generation Report

SKIP DOC Warnings

Uh oh!

github-actions bot commented Dec 23, 2025

SQL Diagram Generation Report

SKIP DOC Warnings

Uh oh!

github-actions bot commented Dec 23, 2025

SQL Diagram Generation Report

Uh oh!

github-actions bot commented Dec 23, 2025

SQL Diagram Generation Report

SKIP DOC Warnings

Uh oh!

github-actions bot commented Dec 24, 2025

SQL Diagram Generation Report

SKIP DOC Warnings

Uh oh!

github-actions bot commented Dec 24, 2025

SQL Diagram Generation Report

Uh oh!

github-actions bot commented Dec 24, 2025

SQL Diagram Generation Report

Uh oh!

github-actions bot commented Dec 24, 2025

SQL Diagram Generation Report

Changed Diagrams

SKIP DOC Warnings

Uh oh!

github-actions bot commented Dec 24, 2025

SQL Diagram Generation Report

Changed Diagrams

SKIP DOC Warnings

Uh oh!

github-actions bot commented Dec 24, 2025

SQL Diagram Generation Report

Changed Diagrams

SKIP DOC Warnings

Uh oh!

github-actions bot commented Dec 24, 2025

SQL Diagram Generation Report

Changed Diagrams

SKIP DOC Warnings

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants