Skip to content

Fixed type declarations #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrew-svirin merged 1 commit into from
Sep 25, 2025
Merged

Fixed type declarations #233

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Builders/Document/CustomerUrgentCreditTransferBuilder.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@
use InvalidArgumentException;

/**
* CustomerCreditTransferBuilder
* Corresponds to EbicsApi\Ebics\Builders\CustomerCreditTransfer\CustomerCreditTransferBuilder but with namespaces
* CustomerUrgentCreditTransferBuilder
* Corresponds to EbicsApi\Ebics\Builders\Document\CustomerCreditTransferBuilder but with namespaces
*
* @license http://www.opensource.org/licenses/mit-license.html MIT License
* @author Jan-Philipp Georg (moori)
Expand Down
7 changes: 3 additions & 4 deletions src/Builders/Document/DocumentBuilder.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,9 @@

use DateTime;
use DOMElement;
use EbicsApi\Ebics\Contracts\OrderDataInterface;
use EbicsApi\Ebics\Contracts\PostalAddressInterface;
use EbicsApi\Ebics\Handlers\Traits\XPathTrait;
use EbicsApi\Ebics\Models\DOMDocument;
use EbicsApi\Ebics\Models\XmlData;
use EbicsApi\Ebics\Services\DOMHelper;
use EbicsApi\Ebics\Services\RandomService;

Expand All @@ -23,7 +22,7 @@ abstract class DocumentBuilder
use XPathTrait;

protected RandomService $randomService;
protected ?DOMDocument $instance = null;
protected ?XmlData $instance = null;
protected string $ns;

public function __construct(
Expand All @@ -35,7 +34,7 @@ public function __construct(
$this->ns = sprintf("urn:iso:std:iso:20022:tech:xsd:%s", $split[0]);
}

public function popInstance(): DOMDocument
public function popInstance(): XmlData
{
$instance = $this->instance;
$this->instance = null;
Expand Down
7 changes: 3 additions & 4 deletions tests/AbstractEbicsTestCase.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
use EbicsApi\Ebics\Builders\Document\CustomerDirectDebitBuilder;
use EbicsApi\Ebics\Builders\Document\CustomerUrgentCreditTransferBuilder;
use EbicsApi\Ebics\Contracts\EbicsClientInterface;
use EbicsApi\Ebics\Contracts\OrderDataInterface;
use EbicsApi\Ebics\Contracts\X509GeneratorInterface;
use EbicsApi\Ebics\EbicsClient;
use EbicsApi\Ebics\Factories\Crypt\RSAFactory;
Expand All @@ -18,12 +17,12 @@
use EbicsApi\Ebics\Models\Crypt\RSA;
use EbicsApi\Ebics\Models\CustomerCreditTransfer;
use EbicsApi\Ebics\Models\CustomerDirectDebit;
use EbicsApi\Ebics\Models\DOMDocument;
use EbicsApi\Ebics\Models\Keyring;
use EbicsApi\Ebics\Models\StructuredPostalAddress;
use EbicsApi\Ebics\Models\UnstructuredPostalAddress;
use EbicsApi\Ebics\Models\User;
use EbicsApi\Ebics\Models\X509\BankX509Generator;
use EbicsApi\Ebics\Models\XmlData;
use EbicsApi\Ebics\Services\DebuggerHttpClient;
use EbicsApi\Ebics\Services\FakerHttpClient;
use EbicsApi\Ebics\Services\FileKeyringManager;
Expand Down Expand Up @@ -246,10 +245,10 @@ public function credentialsDataProvider(int $credentialsId): array
*
* @param string $schema
*
* @return OrderDataInterface
* @return XmlData
* @throws DOMException
*/
protected function buildCustomerCreditTransferV2(string $schema): DOMDocument
protected function buildCustomerCreditTransferV2(string $schema): XmlData
{
$builder = new CustomerUrgentCreditTransferBuilder($schema);
$customerCreditTransfer = $builder
Expand Down
Loading