fix: do not generate invalid initial_values for Signals#869
Closed
tainnok wants to merge 1 commit intoebroecker:developmentfrom
Closed
fix: do not generate invalid initial_values for Signals#869tainnok wants to merge 1 commit intoebroecker:developmentfrom
tainnok wants to merge 1 commit intoebroecker:developmentfrom
Conversation
…re is no initial_value given in arxml-file
Owner
|
should be merged with #879 |
1 similar comment
Owner
|
should be merged with #879 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
!! DRAFT !!
this is part of an bigger change which i tried to split into several pull-requests.
But as the changes depends on each other the splited pull-requests will generate merge-conflicts.
So see this seperated pull-requests as some kind of documentation.
The "big" pull-request which contains everything in a single pull-request which do NOT generate merge-conflicts is: #873
it is possible that an arxml-file does NOT contain an initial_value for an signal.
but the class Signal need an initial_value (which make sense, because some initial-value is needed logically).
The current implementation sets the initial_value to 0 if the INITIAL_VALUE is missing in the arxml-file.
BUT if 0 is not allowed because of min/max value an inconsistent/invalid Signal is generated.
Solution: check if initial_value is between min/max. if not, set it to min.
(more or less it does not matter which value, each value between min/max is just a guess, but the current impementation make the fixed guess '0' without checking if that guess is valid)