Loosen blockformat ID validation to allow for S-ADM frames#197
Merged
Loosen blockformat ID validation to allow for S-ADM frames#197
Conversation
rsjbailey
force-pushed
the
sadm-blockid-fix
branch
from
6111b41 to
85d87c1
Compare
An audioChannelFormat in an S-ADM frame can contain a set of AudioBlockFormats with an initialiser block. This is a special block that has a counter value of 0. It may also contain a run of contiguous blocks that start from some integer n > 1. This commit allows non-contiguous IDs to be added to a document for this case only.
rsjbailey
force-pushed
the
sadm-blockid-fix
branch
from
85d87c1 to
a4afc1e
Compare
Contributor
Author
|
This is a slightly tidied version of the patch I sent over before. The helper function is in a nested namespace so it doesn't pollute folks autocomplete and the variable names have changed. |
davemar-bbc
approved these changes
Feb 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An audioChannelFormat in an S-ADM frame can contain a set of AudioBlockFormats with an initialiser block.
This is a special block that has a counter value of 0. It may also contain a run of contiguous blocks that start from some integer n > 1. This commit allows non-contiguous IDs to be added to a document for this case only.