chore(api): run rector again #7825
Merged
+198
−192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlobeltrame
approved these changes
Jul 22, 2025
api/src/DTO/Invitation.php
Outdated
| uriTemplate: '/invitations/{inviteKey}/find{._format}', // TO DISCUSS: Wouldn't '/{inviteKey}{._format}' be more REST-like | ||
| uriTemplate: '/invitations/{inviteKey}/find{._format}', | ||
| openapi: new OpenApiOperation(description: 'Use myInviteKey to find an invitation in the dev environment.'), | ||
| // TO DISCUSS: Wouldn't '/{inviteKey}{._format}' be more REST-like |
There was a problem hiding this comment.
Move comment up above uriTemplate
|
Wait until #8004 is merged |
BacLuc
force-pushed
the
continue-rector
branch
2 times, most recently
from
09a01d0 to
be1259b
Compare
|
Now that no api PR are open, we could merge this. |
BacLuc
force-pushed
the
continue-rector
branch
from
be1259b to
4db2722
Compare
1 task
Since the last rector PR, rector was updated again and has some more rules. e.g. the sort named parameters rule, for which i waited for a long time. Rector has a bug with this $response variable.
BacLuc
force-pushed
the
continue-rector
branch
from
4db2722 to
d919296
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the last rector PR, rector was updated again and has some more rules. e.g. the sort named parameters rule, for which i waited for a long time.