-
Notifications
You must be signed in to change notification settings - Fork 61
Vue3 migration #8279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
manuelmeister
wants to merge
166
commits into
devel
Choose a base branch
from
vue3
base: devel
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Vue3 migration #8279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
As far as I can tell, this would only affect us if we used the composition api more.
They are needed to build the frontend.
That we can build and deploy the frontend image.
✅ Feature branch deployment ready!
|
…nfig.js We will tackle this later.
Do not remove them yet from the rules section, that can be done later.
The components of the stepper component were renamed. And the stepper now always starts with 0, and you cannot set the step value for the steps anymore, they correspond to their index. (At least with 0 amount of research)
Add remove commented line after mapGetters
It doesn't make sense to have a comment without a comment.
…t.vue When someone makes this work he can remove the selectors and check if they are still needed. For now it would be good to have a clean eslint output.
…Header.vue When someone makes this work he can remove the selectors and check if they are still needed. For now, it would be good to have a clean eslint output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #8271 for todos