.helm: make AUTHENTICATION_TOKEN_TTL configurable for the api #8656
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Feature branch deployment ready!
|
BacLuc
force-pushed
the
make-authenticationTokenTtlConfigurable
branch
from
9f8a152 to
7833886
Compare
BacLuc
force-pushed
the
make-authenticationTokenTtlConfigurable
branch
from
7833886 to
0dd3fee
Compare
BacLuc
force-pushed
the
make-authenticationTokenTtlConfigurable
branch
from
0dd3fee to
369e62a
Compare
Helm has a silly behavior for empty values, see: - helm/helm#13487 .Values.api.authenticationTokenTtl should catch "", nil. Sometimes an empty value ends up as string <no value> which is explicitly checked here.
BacLuc
force-pushed
the
make-authenticationTokenTtlConfigurable
branch
from
369e62a to
e414ad2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helm has a silly behavior for empty values, see:
.Values.api.authenticationTokenTtl should catch "", nil.
Sometimes an empty value ends up as string <no value> which is explicitly checked here.
I configured it for feature branch deployments to 1 hour.