Pratik bacnet implimentation #284
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi @PratikTarpara, Thank you for the PR. I would like to request you to add the description to PR. It will help us to understand the context and make decision. |
Contributor
|
Hi @juileetikekar, Actually, this PR should have not been made in the first because we were still developing and testing the implementation then... But now, it is more stable. We will clean everything and update or create a new PR with respect to the work. |
Contributor
|
Hi @Kaz040, Thank you for the information. If you decide to create a new PR, then please close this PR. Also, please let me know once the final PR is ready to be reviewd and merged into main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.