Skip to content

Add shell script for updating versions#14

Merged
GabyUnalaq merged 4 commits intomainfrom
8_update_versions
Jun 3, 2025
Merged

Add shell script for updating versions#14
GabyUnalaq merged 4 commits intomainfrom
8_update_versions

Conversation

@HorjuRares
Copy link
Contributor

@HorjuRares HorjuRares commented Jun 2, 2025

Issues: #8

Definition of Done

The PR shall be merged only if all items mentioned in CONTRIBUTING.md have been followed. In case an item is not applicable as described, please provide a short explanation in the description.

@HorjuRares HorjuRares requested a review from GabyUnalaq June 2, 2025 12:07
@HorjuRares HorjuRares self-assigned this Jun 2, 2025
@HorjuRares
Copy link
Contributor Author

@GabyUnalaq please take a quick look over this and point out if I missed something or something needs to be changed.

@GabyUnalaq GabyUnalaq added the ready for review The issue is ready for review label Jun 2, 2025
Copy link
Contributor

@GabyUnalaq GabyUnalaq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review finished. There are some places where the version was not changed, some are either part of the documentation, either refer to the link towards the correct version of the documentation.

@GabyUnalaq
Copy link
Contributor

Also, regarding the clippy warning, please add the clippy::struct_field_names tag in src/lib.rs at the 'allow' part, with a small motivation. Because the development occurs on an older version of rust and the CI/CD works with the latest stable one, it is normal to have some issues, especially with clippy.

@HorjuRares
Copy link
Contributor Author

HorjuRares commented Jun 3, 2025

@GabyUnalaq I've went through the findings. Please check.
I still see that we have not addressed the issue of compatibility tables should those be addressed by this issue or be updated manually with new releases appearing?

@GabyUnalaq
Copy link
Contributor

@GabyUnalaq I've went through the findings. Please check. I still see that we have not addressed the issue of compatibility tables should those be addressed by this issue or be updated manually with new releases appearing?

The script should not update the compatibility table, because it's more complicated than replacing a string. What you can do in the script is, in case the user changes the ankaios_sdk version, to just show a message informing the user that he might need to change the tables (the one in ReadMe.md and lib.rs).

Copy link
Contributor

@GabyUnalaq GabyUnalaq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more finding

Co-authored-by: Tomuta Gabriel <gaby_unalaq@yahoo.com>
Copy link
Contributor

@GabyUnalaq GabyUnalaq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@GabyUnalaq GabyUnalaq linked an issue Jun 3, 2025 that may be closed by this pull request
3 tasks
@GabyUnalaq GabyUnalaq merged commit fcdcbbb into main Jun 3, 2025
9 checks passed
@GabyUnalaq GabyUnalaq deleted the 8_update_versions branch June 3, 2025 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready for review The issue is ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Script for updating the version

2 participants