Conversation
|
@GabyUnalaq please take a quick look over this and point out if I missed something or something needs to be changed. |
GabyUnalaq
left a comment
There was a problem hiding this comment.
Review finished. There are some places where the version was not changed, some are either part of the documentation, either refer to the link towards the correct version of the documentation.
|
Also, regarding the clippy warning, please add the |
|
@GabyUnalaq I've went through the findings. Please check. |
The script should not update the compatibility table, because it's more complicated than replacing a string. What you can do in the script is, in case the user changes the ankaios_sdk version, to just show a message informing the user that he might need to change the tables (the one in ReadMe.md and lib.rs). |
Co-authored-by: Tomuta Gabriel <gaby_unalaq@yahoo.com>
Issues: #8
Definition of Done
The PR shall be merged only if all items mentioned in CONTRIBUTING.md have been followed. In case an item is not applicable as described, please provide a short explanation in the description.