Connection check fails on insufficient privileges#18
Merged
GabyUnalaq merged 3 commits intomainfrom Jun 10, 2025
Merged
Conversation
HorjuRares
added
ready for review
GabyUnalaq
requested changes
Jun 10, 2025
Contributor
GabyUnalaq
left a comment
GabyUnalaq
left a comment
There was a problem hiding this comment.
There are 2 cases for when the check if successful:
- The CompleteState with only the apiVersion is returned, thus the connection is fine.
- The request is blocked due to not enough privileges, thus the connection is fine.
In all other cases (ConnectionClosed or ProtocolException), the connection check fails. Because the connection_established variable never gets set to True if the apiVersion is successfully returned, the error line in get state for subsequent requests never get's logged in case of a privilege issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues: #16
Definition of Done
The PR shall be merged only if all items mentioned in CONTRIBUTING.md have been followed. In case an item is not applicable as described, please provide a short explanation in the description.