Skip to content

Resolvable secrets #3831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
+646 −146
Open

Resolvable secrets #3831

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
c1a4229
feat(model): Add a `ResolvableSecret` class
mnonnenmacher Oct 28, 2025
0d344d7
feat(model): Add a `ResolvablePluginConfig`
mnonnenmacher Oct 14, 2025
976dbe3
feat: Use `ResolvablePluginConfig` in job configurations
mnonnenmacher Oct 28, 2025
987936a
refactor(workers): Add `SecretService` to `WorkerContextImpl`
mnonnenmacher Nov 4, 2025
d077000
test(workers): Rename a test class
mnonnenmacher Nov 4, 2025
95b1adb
refactor(workers): Turn a function into an expression function
mnonnenmacher Nov 4, 2025
ad53237
feat(secret-service): Add a function to get the value of a secret
mnonnenmacher Nov 4, 2025
4e59bdd
test(workers): Create a helper object centrally
mnonnenmacher Nov 4, 2025
8b54d41
test(workers): Remove unused constructor arguments
mnonnenmacher Nov 4, 2025
c747645
refactor(workers): Use the `SecretService` for resolving secret values
mnonnenmacher Nov 4, 2025
8bb6cbf
test(workers): Remove redundant qualifiers
mnonnenmacher Nov 10, 2025
44d365e
feat(workers): Support user secrets in plugin configs
mnonnenmacher Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions workers/common/src/main/kotlin/common/context/WorkerContextImpl.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,9 +132,8 @@ internal class WorkerContextImpl(
override suspend fun resolveSecret(secret: Secret): String =
singleTransform(secret, secretsCache, this::resolveSecret, ::extractSecretKey)

override suspend fun resolveSecrets(vararg secrets: Secret): Map<Secret, String> {
return parallelTransform(secrets.toList(), secretsCache, this::resolveSecret, ::extractSecretKey)
}
override suspend fun resolveSecrets(vararg secrets: Secret): Map<Secret, String> =
parallelTransform(secrets.toList(), secretsCache, this::resolveSecret, ::extractSecretKey)
Copy link
Contributor

@sschuberth sschuberth Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated to this change as it aligns with 133 in the following regard, but as a general those this qualifiers do not seem to be necessary.


override suspend fun resolvePluginConfigSecrets(
config: Map<String, ResolvablePluginConfig>?
Expand Down