Skip to content

Conversation

@Etsija
Copy link
Contributor

@Etsija Etsija commented Nov 4, 2025

This PR introduces a new component "search", which is implemented with the sliced architecture. Initial implementation for the service and endpoint returns a list of all ORT run ids which include a given ORT ID. The service can later on be extended to other search functionality, for example to provide all products/repositories that are affected by a given vulnerability.

Screenshot from 2025-11-04 11-37-11 Screenshot from 2025-11-04 11-38-10

Details:

  • so far, only ORT IDs are used for searching. PURL implementation (taking into account curated PURLs) will later on extend this
  • the search can be scoped to a specific organization, organization+product, or organization+product+repository
  • scoping parameters are validated (eg. there can be no search with productId but without a given organizationId
  • the search is regEx based, so for example substring of a package ID can be used

Please see the commits for details.

@Etsija Etsija marked this pull request as ready for review November 4, 2025 10:19
@Etsija
Copy link
Contributor Author

Etsija commented Nov 4, 2025

NOTE: as decided in today's ORT Server Community Meeting, this PR will stay on hold until after the new authorization concept is fully merged (it needs then some changes to permissions handling and filtering the search results). Meanwhile, I am still open to general review comments regarding my PR.

@sschuberth sschuberth marked this pull request as draft November 4, 2025 10:55
@sschuberth sschuberth added the on hold Issues or PRs that are blocked. label Nov 4, 2025
.gitignore Outdated
.bmad-core/
.gemini/
.github/chatmodes/
docs/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that ignoring a "docs" directory is too generic.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That .gitignore change is old anyway, so I will remove the corr. documents and remove the commit.

The helper function simplifies testing of search service.

Signed-off-by: Jyrki Keisala <[email protected]>
Signed-off-by: Jyrki Keisala <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

on hold Issues or PRs that are blocked.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants