feat(kubernetes): Allow adding custom labels to worker pods#4526
Merged
mnonnenmacher merged 1 commit intomainfrom Feb 19, 2026
Merged
feat(kubernetes): Allow adding custom labels to worker pods#4526mnonnenmacher merged 1 commit intomainfrom
mnonnenmacher merged 1 commit intomainfrom
Conversation
mnonnenmacher
requested review from
MarcelBochtler,
bs-ondem,
nnobelis,
oheger-bosch,
sschuberth and
wkl3nk
as code owners
sschuberth
reviewed
Feb 19, 2026
Contributor
There was a problem hiding this comment.
Maybe it is just me, but the exact meaning of this sentence is not clear to me. It is supposed to mean that the reserved labels are ignored in the map, but my first interpretation was that they will not be added (i.e., the adding is ignored) if they are included in the map. To make this fully clear, maybe use something like "... are added by default and cannot be overridden via this mechanism." ? Also in other places.
Contributor
Author
There was a problem hiding this comment.
I have reworded the sentences, it should be clearer now.
mnonnenmacher
force-pushed
the
worker-labels
branch
from
d7700a2 to
d69ed62
Compare
Add a config property for the `KubernetesSenderConfig` to allow adding custom labels for the created jobs. Signed-off-by: Martin Nonnenmacher <martin.nonnenmacher@doubleopen.org>
mnonnenmacher
force-pushed
the
worker-labels
branch
from
d69ed62 to
57ed9d7
Compare
sschuberth
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a config property for the
KubernetesSenderConfigto allow adding custom labels for the created jobs.